1844528 - Change ErrorReporter::isOnThisLine to use std::optional instead of an out parameter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[[:sergesanspaille]]

This positively impacts code generation under -ftrivial-auto-var-init as this make it possible for the compiler to understand it does not need to initialize the out parameter.

Interestingly this also leads to better code generation.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1844528 - Change ErrorReporter::isOnThisLine to use std::optional instead of an out parameter r=arai

This positively impacts code generation under -ftrivial-auto-var-init as
this make it possible for the compiler to understand it does not need to
initialize the out parameter.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dabbb6c3aec
Change ErrorReporter::isOnThisLine to use std::optional instead of an out parameter r=arai

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0dabbb6c3aec