1844530 - Add PDF as a document type you can filter on when opening a local file (CTRL+O)

Status: VERIFIED FIXED

(Core :: Widget, enhancement)

Description

[Pascal Chevrel (relman team) -> :pascalc]

Attachment: Drop down filter list (in French)

1/ In Firefox on Linux open a local file (Ctrl+O)
2/ Click on the filter dropdown button in the GTK file chooser

ER:
Have an option to filter PDF files

AR:
I can filter on HTML, Images or XML only. Filtering files on PDFs seems like a very common use case now that we have a built-in PDF viewer/Editor.

I don't know what the filtering options in this dialog are on macOS and Windows as I don't have one of them at hand, I suppose that this is something that can be provided as a parameter to the OS filepicker so maybe this is a multiplatform bug and not just GTK.

I am attaching a screenshot of the drop down list in the GTK file picker for clarity.

Thanks

Comment 1

[Mike Hommey [:glandium]]

FWIW, there's a similar filtering drop down if you click "Options" on a mac, and it has the same items.

Comment 2

[Mike Hommey [:glandium]]

Aaaand same on Windows.

Comment 3

[Mike Hommey [:glandium]]

The filters are here: https://searchfox.org/mozilla-central/rev/8d43262674d6c6d469b821cca579b1240ebb42a5/widget/nsBaseFilePicker.cpp#194-233
So it's common to all widgets.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

I guess it should not be too hard to fix
I think Calixte can fix it easily

Comment 5

[Calixte Denizet (:calixte)]

Attachment: Bug 1844530 - Add an option to filter pdf files in the file chooser r=spohl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f38858dd080
Add an option to filter pdf files in the file chooser r=spohl

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9f38858dd080

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 117.0a1 (2023-07-20) on Windows 10x64. There is no PDF file filter after opening the file chooser (Ctrl+ O).
The PDF file filter is present in Firefox 117.0b6 file chooser and works as expected. Tested on macOS 13, Windows 10x64, and Ubuntu 22.