1844536 - Cleanup code around scopes and mapping scopes

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

Lets improve the code around map scopes for maintainability

• Add relevant comments
• Clean-up unused code

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1844536 - [devtools] Remove unused toggle scope props r=#devtools-reviewers

Depends on D186788

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1844536 - [devtools] Cleanup all the util code around scopes r=#devtools-reviewers

Depends on D186871

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1844536 - [devtools] Remove unused map scopes feature pref r=#devtools-reviewers

This patch removes the feature pref for map scopes devtools.debugger.features.map-scopes which is not used.
The pref which is actually used is devtools.debugger.map-scopes-enabled

Depends on D186872

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1844536 - [devtools] Remove isGenerated util and access .isOriginal property directly r=#devtools-reviewers

Depends on D186872

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1109b400168a
[devtools] Remove unused toggle scope props r=devtools-reviewers,ochameau

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4896119e3a13
[devtools] Cleanup all the util code around scopes r=devtools-reviewers,ochameau

Comment 7

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1844536 - [devtools] Use shared utils for accessing scope nodes r=#devtools-reviewers

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1109b400168a

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4896119e3a13

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae0767d15951
[devtools] Remove isGenerated util and access .isOriginal property directly r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/72c09a220d98
[devtools] Use shared utils for accessing scope nodes r=devtools-reviewers,ochameau

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ae0767d15951
https://hg.mozilla.org/mozilla-central/rev/72c09a220d98

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e8113033ae3
[devtools] Remove unused map scopes feature pref r=devtools-reviewers,ochameau,perftest-reviewers,sparky

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7e8113033ae3