1844572 - PDF annotations not saved on certain PDFs

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Paul Menzel]

Attachment: EDV-Bestellung_2010.pdf

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

This is a regression since at least Firefox 115.0. It also does not work with Nightly 117.0a1 (20230715213801).

Open the attached PDF, make annotation and add text, and save it.

Actual results:

The annotations and added text are not saved.

Expected results:

It should be saved.

We only found this one PDF, that worked in the past. It works with other PDF files. Re-rendering the PDF file by plainly printing it, it works again.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::PDF Viewer' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Castelluccio [:marco]]

Could you try using mozregression to figure out exactly what caused this issue?

Comment 3

[Paul Menzel]

Unfortunately I never got it to work, and do not have time to further look into it. A colleague reported, that they tried older versions, and it didn’t work in 112.0 (from April 2023) either. But they are pretty, pretty sure it had worked in the past.

Comment 4

[Marco Castelluccio [:marco]]

I can reproduce, I'll try to use mozregression myself.

Comment 5

[Calixte Denizet (:calixte)]

It's because the Acroform entry in Root isn't a reference and we're finally throwing when we try to write the acroformRef which is null:
https://github.com/mozilla/pdf.js/blob/0702663b7d994bf363328d6b818ded30605a5378/src/core/writer.js#L266C14
Since Root should be a reference (from specs Required; shall be an indirect reference), I think we must rewrite it in such case.

Comment 6

[Marco Castelluccio [:marco]]

10:18.83 INFO: Last good revision: ef7f2899709705172b238d1ef7b9022ed98b290f
10:18.83 INFO: First bad revision: b78719ac48b811337492748d74fa73013b3e752f
10:18.83 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef7f2899709705172b238d1ef7b9022ed98b290f&tochange=b78719ac48b811337492748d74fa73013b3e752f

Comment 7

[Calixte Denizet (:calixte)]

That said in this case we don't have to update Acroform.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800502

Comment 9

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Don't replace Acroform dictionary if nothing has changed when saving (bug 1844572) (#16718)

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Calixte Denizet (:calixte)]

Done in bug 1845506.