Closed Bug 1844666 Opened 2 years ago Closed 2 years ago

Clean up nav history observers.

Categories

(Toolkit :: Places, task, P5)

Product:
Toolkit
Component:
Places
Type:
task

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 obsolete file)

No description provided.

We always store them as weak so let's just do that.

This is blocked on a review question.

Severity: -- → N/A
Priority: -- → P5

Emilio, is this bug still valid, or was the patch based on wrong assumptions?
To me it looks like we don't always keep a weak ref, as the patch suggests, since aOwnsWeak is an optional param that xpcom should set to false.

Flags: needinfo?(emilio)

Yeah, I think it was wrong.

Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Attachment #9344939 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: