Closed
Bug 1844745
Opened 3 years ago
Closed 3 years ago
Rename the "id" from NavigationManager events to "navigationId"
Categories
(Remote Protocol :: WebDriver BiDi, task, P3)
Remote Protocol
WebDriver BiDi
Tracking
(firefox118 fixed)
RESOLVED
FIXED
118 Branch
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: jdescottes, Assigned: rayyanrsarkhot, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
See https://phabricator.services.mozilla.com/D184099#inline-1020403, id is too generic and might be confusing.
Should be fixed in all events emitted from https://searchfox.org/mozilla-central/source/remote/shared/NavigationManager.sys.mjs
|
Reporter | |
Comment 1•3 years ago
|
||
This could be a good first bug
|
||
Updated•3 years ago
|
Summary: Rename the `id` from NavigationManager events to navigationId → Rename the "id" from NavigationManager events to "navigationId"
|
||
Updated•3 years ago
|
Assignee: nobody → rayyanrsarkhot
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6ca3fcf52fd
Renamed id from NavigationManager events to navigationId. r=Sasha,webdriver-reviewers
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
|
||
Comment 5•3 years ago
|
||
Hey Rayyan, great work on the bug!
Would you be interested on picking up something else? Let us know here or in webdriver channel on Matrix.
You need to log in
before you can comment on or make changes to this bug.
Description
•