1844755 - Consider to not create ServoStyleSet for data documents

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

See the profile in bug 1844430.
Could we not create the ServoStyleSet or create it lazily?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://share.firefox.dev/3OnGJXr
Creating ServoStyleSet is still 4% of DOMParser::ParseFromString.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1844755 - Consider to not create ServoStyleSet for data documents, r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1426851ae30
Consider to not create ServoStyleSet for data documents, r=emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_printpreview.xhtml

• backout: https://hg.mozilla.org/integration/autoland/rev/fe4e67ae521b5b29efef2be635e0085c2aad1448
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=OrGuGyxmTG-fJb4dDXqhIQ.0&revision=f1426851ae3049d6f44ef0e9da7b601c73ea435a
• failure log: https://treeherder.mozilla.org/logviewer?job_id=433395111&repo=autoland&lineNumber=5711

[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - TEST-UNEXPECTED-FAIL | layout/base/tests/chrome/test_printpreview.xhtml | Printing printpreview_quirks.html and printpreview_quirks_ref.html should produce the same results - got false, expected true
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - compareFiles@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:504:5
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - async*runTest11@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:509:9
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - setTimeout handler*runTest10/<@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:447:48
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - FrameRequestCallback*runTest10@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:447:24
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - async*runTest9/<@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:401:48
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - FrameRequestCallback*runTest9@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:401:24
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - async*runTest8/<@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:363:48
[task 2023-10-23T10:34:52.564Z] 10:34:52     INFO - FrameRequestCallback*runTest8@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:363:24
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - async*runTest7/<@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:337:48
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - FrameRequestCallback*runTest7@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:337:24
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - async*runTest6end/<@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:315:48
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - FrameRequestCallback*runTest6end@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:315:24
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - async*runTest6@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:308:13
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - setTimeout handler*runTest5@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:299:13
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - async*runTest4end@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:288:3
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - async*runTest4@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:281:13
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - setTimeout handler*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:256:13
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - setTimeout handler*compareFormElementPrint@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:274:13
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - async*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:252:28
[task 2023-10-23T10:34:52.565Z] 10:34:52     INFO - setTimeout handler*compareFormElementPrint@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:274:13
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - async*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:252:28
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - setTimeout handler*compareFormElementPrint@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:274:13
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - async*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:252:28
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - setTimeout handler*compareFormElementPrint@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:274:13
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - async*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:252:28
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - setTimeout handler*compareFormElementPrint@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:274:13
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - async*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:252:28
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - setTimeout handler*compareFormElementPrint@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:274:13
[task 2023-10-23T10:34:52.566Z] 10:34:52     INFO - async*runTest3@chrome://mochitests/content/chrome/layout/base/tests/chrome/printpreview_helper.xhtml:252:28
[task 2023-10-23T10:34:52.567Z] 10:34:52     INFO - Comparing test_document_adopted_styles.html with test_document_adopted_styles_ref.html
[task 2023-10-23T10:34:52.567Z] 10:34:52     INFO - GECKO(3605) | [Parent 3605, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1224

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cb4268de33e
Consider to not create ServoStyleSet for data documents, r=emilio

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1cb4268de33e