1844830 - Optimize textrun initialization, for Editor-TipTap

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task)

Description

[Jonathan Kew [:jfkthame]]

+++ This bug was initially created as a clone of Bug #1844464 +++

The patches in bug 1844464 should improve the font-shaping performance in this test. Here, I'm hoping to optimize some of the other parts of textrun construction as well, as I think there are some (minor) gains to be had.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1844830 - patch 1 - Convert gfxFont's shaped-word cache from nsTHashtable to mozilla::HashMap for faster performance. r=#gfx-reviewers

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1844830 - patch 2 - Micro-optimize grapheme cluster checks used during textrun creation. r=#gfx-reviewers

Depends on D184311

Comment 3

[Jonathan Kew [:jfkthame]]

In local (non-PGO) builds, I'm seeing an improvement of around 2-4% on the Editor-TipTap score with these patches.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1844830 - patch 3 - gfxFontGroup::GetFontAt should take an unsigned index. r=#gfx-reviewers

There's no reason for this to be signed, and the callers are using an unsigned index already.

(Won't make any difference, especially once the optimizer has had a look at it; this is just
a bit of cleanup noticed in passing.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12af03069bf1
patch 1 - Convert gfxFont's shaped-word cache from nsTHashtable to mozilla::HashMap for faster performance. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/7f0c75c707f8
patch 2 - Micro-optimize grapheme cluster checks used during textrun creation. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/6d887cf7ea09
patch 3 - gfxFontGroup::GetFontAt should take an unsigned index. r=gfx-reviewers,lsalzman

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/12af03069bf1
https://hg.mozilla.org/mozilla-central/rev/7f0c75c707f8
https://hg.mozilla.org/mozilla-central/rev/6d887cf7ea09