Closed Bug 1844867 Opened 2 years ago Closed 1 year ago

Temporarily disable uniformity analysis for render shaders, leave on for compute shaders

Categories

(Core :: Graphics: WebGPU, defect, P3)

Product:
Core
Component:
Graphics: WebGPU
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ErichDonGubler, Assigned: teoxoy)

References

(Blocks 1 open bug)

Details

Depends on naga#1744.

Known place(s) where an out-of-date uniformity analysis is currently hurting users:

  1. This message in #wgpu:matrix.org by @jaspperrlz, who notes transpiling GLSL shaders to WGSL, which then fail validation in uniformity analysis.
  2. Bug 1844867, where a derivative operation was used and already proven to be working in Chrome.
Assignee: egubler → nobody

Naga's current uniformity analysis is stricter than the spec's. Uniformity analysis isn't essential for vertex and fragment shaders, but it is required for reliable execution of compute shaders. For letting WebGPU ride the trains, we should just turn off the analysis for rendering, and accept the excess strictness on compute shaders. We can bring the analysis into alignment with the spec after WebGPU rides the trains.

Summary: Uniformity analysis in WebGPU is out-of-date → Temporarily disable uniformity analysis for render shaders, leave on for compute shaders
Assignee: nobody → ttanasoaia
Status: NEW → ASSIGNED
Blocks: 1850205

https://github.com/gfx-rs/naga/pull/2515 will take care of this.

Depends on: 1857243
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.