Closed Bug 1845085 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41156 - Update import-assertions tests to new semantics

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41156 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41156
Details from upstream follow.

Nicolò Ribaudo <nribaudo@igalia.com> wrote:

Update import-assertions tests to new semantics

This PR is best reviewed commit-by-commit.

  1. Update import-assertions tests to new semantics: the import attributes TC39 proposal, previously known as "import assertions", now throws on unrecognized keys.
  2. Copy import-assertions tests to import-attributes (with): the proposal now uses the with keyword instead of assert. assert is still an optional part of the proposal, but engines are discouraged from implementing it and it's just a syntactic alias for with. The assert tests could be eventually removed from WPT (it similar to how, for example, tests test document.createElement but not document["createElement"]), but for now I'm keeping them for engines that currently only support assert.
  3. Copy {css,json}-module to {css,json}-module-assertions is just copy/pasting in preparation of the next commit
  4. assert -> with in {css,json}-module folders changes the keyword from assert to with in all those tests. I chose to go with the *-module/*-module-assertions folder names, and not *-module-attributes/*-module-assertions or ``-module-attributes/-module`, because `with` should be considered the default.

Closes https://github.com/tc39/proposal-import-attributes/issues/146

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 83 tests and 6 subtests

Status Summary

Firefox

OK : 17
PASS : 10
FAIL : 40
TIMEOUT: 6
ERROR : 63
NOTRUN : 42

Chrome

OK : 67
PASS : 181
FAIL : 70
TIMEOUT: 2
ERROR : 15
NOTRUN : 20

Safari

OK : 51
PASS : 89
FAIL : 85
TIMEOUT: 2
ERROR : 31
NOTRUN : 56

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Pushed by ctuns@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/a4dd9c2afbca
[wpt PR 41156] - Update import-assertions tests to new semantics, a=testonly
https://hg.mozilla.org/mozilla-central/rev/080c8e034ab9
[wpt PR 41156] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a4dd9c2afbca
https://hg.mozilla.org/mozilla-central/rev/080c8e034ab9

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.