Open Bug 1845192 Opened 2 years ago Updated 3 months ago

System extensions fail to load in local builds on Windows (when using symlinks)

Categories

(WebExtensions :: General, defect, P5)

defect

Tracking

(firefox-esr102 wontfix, firefox-esr115 wontfix, firefox115 wontfix, firefox116 wontfix, firefox117 wontfix)

Tracking Status
firefox-esr102 --- wontfix
firefox-esr115 --- wontfix
firefox115 --- wontfix
firefox116 --- wontfix
firefox117 --- wontfix

People

(Reporter: nalexander, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This is Bug 1377614, but for Windows. It happens now because we use symlinks on Windows (see Bug 1643072 and friends); at the time of the original work, that wasn't the case. It's not particularly onerous to fetch MOZ_DEVELOPER_REPO_DIR from the environment and use it, which avoids a slew of errors like:

Loading failed for the <script> with source "moz-extension://..."

Set release status flags based on info from the regressing bug 1643072

:saschanaz, since you are the author of the regressor, bug 1643072, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Yeah, I can confirm this issue even with ./mach run, not sure why MOZ_DEVELOPER_REPO_DIR is not applied there?

But I have no clue where to start investigating. Rob, do you perhaps have some quick insight where such file system access happens from extensions?

Flags: needinfo?(krosylight) → needinfo?(rob)

(In reply to Kagami [:saschanaz] (they/them) from comment #3)

But I have no clue where to start investigating. Rob, do you perhaps have some quick insight where such file system access happens from extensions?

I can help with this, I have a hacky patch to address locally.

:saschanaz: this is really hacky, but I think the idea is clear. Cleaned up, this could address the issue.

Flags: needinfo?(rob) → needinfo?(krosylight)

Oh thanks, but you mean you figured it all out and are not going to finish it? 🙂

Flags: needinfo?(krosylight) → needinfo?(nalexander)

(In reply to Kagami [:saschanaz] (they/them) from comment #7)

Oh thanks, but you mean you figured it all out and are not going to finish it? 🙂

Pretty much -- I figured out what was happening, addressed it so that I could test some things locally, and need to move on. I'd appreciate it getting improved because it's confusing as is.

Flags: needinfo?(nalexander)
Component: Request Handling → General

The severity field is not set for this bug.
:rpl, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(lgreco)

This seems to be a problem with local builds, not with official builds. Since we have not heard anything other than this report, we'll triage this with low priority. If this issue is more severe, please let us know and we can reconsider.

While looking at the proposed patch, I noticed the use of an environment variable to change behavior. I'm wondering whether that would could increase the risk of abuse to our users.

Severity: -- → S4
Flags: needinfo?(lgreco)
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: