1845192 - System extensions fail to load in local builds on Windows (when using symlinks)

Status: NEW

(WebExtensions :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is Bug 1377614, but for Windows. It happens now because we use symlinks on Windows (see Bug 1643072 and friends); at the time of the original work, that wasn't the case. It's not particularly onerous to fetch MOZ_DEVELOPER_REPO_DIR from the environment and use it, which avoids a slew of errors like:

Loading failed for the <script> with source "moz-extension://..."

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1643072

:saschanaz, since you are the author of the regressor, bug 1643072, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Yeah, I can confirm this issue even with ./mach run, not sure why MOZ_DEVELOPER_REPO_DIR is not applied there?

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

But I have no clue where to start investigating. Rob, do you perhaps have some quick insight where such file system access happens from extensions?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Kagami [:saschanaz] (they/them) from comment #3)

But I have no clue where to start investigating. Rob, do you perhaps have some quick insight where such file system access happens from extensions?

I can help with this, I have a hacky patch to address locally.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1845192 - Hack `MOZ_DEVELOPER_REPO_DIR` on Windows.

Comment 6

[Nick Alexander :nalexander [he/him]]

:saschanaz: this is really hacky, but I think the idea is clear. Cleaned up, this could address the issue.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Oh thanks, but you mean you figured it all out and are not going to finish it? 🙂

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Kagami [:saschanaz] (they/them) from comment #7)

Oh thanks, but you mean you figured it all out and are not going to finish it? 🙂

Pretty much -- I figured out what was happening, addressed it so that I could test some things locally, and need to move on. I'd appreciate it getting improved because it's confusing as is.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rpl, could you have a look please?

For more information, please visit BugBot documentation.