1845305 - [ES][toysrus.es] CC dropdown is not displayed for any of the CC eligible fields

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-07-25_16h38_42.mp4

Found in

• 117.0a1

Affected versions

• 117.0a1

Tested platforms

• Affected platforms: Windows 10

Preconditions

• browser.search.region = ES
• Have at least one CC already saved

Steps to reproduce

1. Reach the payment form on https://www.toysrus.es
2. Click on any CC eligible field

Expected result

• CC dropdown is displayed for any of the CC fields

Actual result

• CC dropdown is not displayed for any of the CC fields

Regression range

• N/A

Additional notes

• Not reproducible on Chrome, the CC dropdown is displayed and the autofill is working ok there.
• Fathom Fox Sample

Comment 1

[Dimi Lee [:dimi]]

Looks like when we focus on the <input> field, the event target has null principal[1] so we don't run the formautofill code?

[1] https://searchfox.org/mozilla-central/rev/0058dbdd1c2eb9164e195082d18f3a657f291824/toolkit/components/formautofill/FormAutofillChild.sys.mjs#97

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Fwiw you might want to check this to know where the null principal came from.

Comment 3

[Johannes]

Attachment: Bug 1845305 - add tests for sandboxed iframe autocompletion r=dimi

Note the test fails, and the fix will be provided via the next patch in this stack.

Comment 4

[Johannes]

Attachment: Bug 1845305 - remove null principal check for autocompletion r=dimi

which has been unitentionally copied. Removing the principal enables autocompletion in sandboxed iframe forms.

Comment 5

[Johannes]

Attachment: Bug 1845305 - add tests for sandboxed iframe autocompletion r=dimi

Note the test fails, and the fix will be provided via the next patch in this stack.

Comment 6

[Johannes]

Attachment: Bug 1845305 - remove null principal check for autocompletion r=dimi

Removing the null principal check enables autocompletion in sandboxed iframe forms.

fyi: tests are in the previous commit of the stack.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b23238ed9c
add tests for sandboxed iframe autocompletion r=dimi
https://hg.mozilla.org/integration/autoland/rev/45324f226216
remove null principal check for autocompletion r=dimi

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/25b23238ed9c
https://hg.mozilla.org/mozilla-central/rev/45324f226216

Comment 9

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Nightly 125.0a1 (2024-06-03). The CC dropdown is now displayed and all the eligible CC form fields are autofilled accordingly.