1845400 - Contextual Services' `quick_suggest.reporting_url` should be on the "quick-suggest" ping, not "top-sites"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten|PTO (back March 17)]

Not sure how this happened or escaped review, but I'm glad we're catching it now.

This bug is a one-line YAML fix for send_in_pings plus an annotation in Glean Dictionary to note when it was reporting, noticed, fixed, and shipped.

Comment 1

[Chris H-C :chutten|PTO (back March 17)]

Attachment: Bug 1845400 - reporting_url should be sent on 'quick-suggest' ping r?perry.mcmanis!

Comment 2

[Chris H-C :chutten|PTO (back March 17)]

Comment on attachment 9345657 [details]
Bug 1845400 - reporting_url should be sent on 'quick-suggest' ping r?perry.mcmanis!

Beta/Release Uplift Approval Request

• User impact if declined: We'll be losing data
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is putting the metric in the correct ping (like the rest of the metrics in the category). No value for send_in_pings is risky, and correcting it to "quick-suggest" is no different.
• String changes made/needed:
• Is Android affected?: No

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5d1d5d64290
reporting_url should be sent on 'quick-suggest' ping r=nanj

Comment 4

[Chris H-C :chutten|PTO (back March 17)]

(I know this is very late to be asking for an uplift. And saying no is fine. It just means I'll need to put in an annotation that "For Fx116 this was incorrectly absent from the "quick-suggest" ping" which will hamper our abilities to promptly remove PingCentre)

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9345657 [details]
Bug 1845400 - reporting_url should be sent on 'quick-suggest' ping r?perry.mcmanis!

Switching flag to release since we are in RC week. Ill keep this in mind for any respins

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d5d1d5d64290

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9345657 [details]
Bug 1845400 - reporting_url should be sent on 'quick-suggest' ping r?perry.mcmanis!

Approved for 116.0rc2

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/22256daf88b9