1845413 - High memory usage with Dark Space theme

Status: RESOLVED INCOMPLETE

(Core :: Graphics: WebRender, defect)

Description

[alberto.d.lopez501]

Attachment: memory-report.json

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I'm running multiple tabs at once

Actual results:

Firefox takes up a lot of application memory

Expected results:

Firefox shouldn't be crashing

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Performance' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Andrew McCreight [:mccr8]]

There's not a lot to go on there. The memory report doesn't look too out of the ordinary.

I do see this in there: 3,264.75 MB ── resident-peak

So the main process memory was very high at some point, but it went down eventually.

gfx memory also looks fairly high:

730.95 MB (100.0%) -- gfx
└──730.95 MB (100.0%) -- webrender
   ├──498.66 MB (68.22%) -- textures
   │  ├──246.35 MB (33.70%) ── render-texture-hosts
   │  ├──128.00 MB (17.51%) ── render-targets
   │  ├───74.12 MB (10.14%) -- texture-cache
   │  │   ├──74.00 MB (10.12%) ── atlas
   │  │   └───0.12 MB (00.02%) ── standalone
   │  ├───32.00 MB (04.38%) ── depth-targets
   │  ├───16.81 MB (02.30%) ── swap-chains
   │  └────1.39 MB (00.19%) ++ (5 tiny)
   └──232.29 MB (31.78%) -- images/mapped_from_owner

I noticed you have the "Dark space" extension installed. That has caused us a lot of memory issues in the past. We've fixed one of them, but I think there's still at least one we haven't fixed. Do you have any animated theme installed for that? You could try disabling that. Did you have some of your windows minimized or blocked by other windows?

Comment 3

[alberto.d.lopez501]

Hello, thank you for getting back to me.
Yes, I have the dark space dynamic theme, however I just switched it for a non-dynamic dark one.

Usually, Firefox will start consuming massive amounts of memory, think in the 500GB (or some ridiculous number) if I leave it open overnight, close my mac, and begin using my laptop in the morning.

Comment 4

[Timothy Nikkel (:tnikkel)]

(In reply to Andrew McCreight [:mccr8] from comment #2)

I noticed you have the "Dark space" extension installed. That has caused us a lot of memory issues in the past. We've fixed one of them, but I think there's still at least one we haven't fixed.

Hmm, I was under the impression that we fixed all the known issues. Was there something specific you were thinking of that was not fixed? Or just the general impression since there are still followup bugs open relating to that issue.

I will also try to deduce what is going on in this bug.

Comment 5

[Timothy Nikkel (:tnikkel)]

Oh, actually, I think I can answer that question and explain this bug. In 115 minimized windows still suffer from the animated theme memory leak (which is a long standing issue). (Occluded windows was what all the fuss was about the last few releases.)

116 should fix the minimized window problem and there should be no known issues like this remaining (if there are we would like to know about it). Bug 1830753 and bug 1839109 are the bugs that should resolve this issue in 116. 116 will be released next week, or 116 beta is available to use right now. Once 116 is released I'll ask the reporter to confirm that the problem goes away for them with 116.

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Timothy Nikkel (:tnikkel) from comment #4)

Hmm, I was under the impression that we fixed all the known issues. Was there something specific you were thinking of that was not fixed? Or just the general impression since there are still followup bugs open relating to that issue.

Yeah, I was thinking of the minimized window problem. I'd forgotten that the patch had landed for it.

Comment 7

[Timothy Nikkel (:tnikkel)]

116 is out now. Could you update and test and see if you are still seeing this problem?

Comment 8

[dark_skeleton]

I'm on 116.0.1 and as of yesterday this bug was still very much present. I was also using this theme and thought I'm going crazy - issue hasn't happened again since disabling the theme.

If I'm putting my observations together correctly the issue would skyrocket when Windows is Locked and/or monitors turn off for sleep (I use a short delay due to using an OLED screen).

On 16GB RAM the memory usage would climb to 95%, crash other apps, with over 45GB in "commited memory", however task manager would not indicate that Firefox is using this crazy amount of memory.

Clicking "Minimize memory usage" in about:memory or simply closing the browser would bring the memory usage down to more reasonable levels, but not before some apps already crashed from OOM situation :)

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

A needinfo is requested from the reporter, however, the reporter is inactive on Bugzilla. Given that the bug is still UNCONFIRMED, closing the bug as incomplete.

For more information, please visit BugBot documentation.

Comment 10

[Timothy Nikkel (:tnikkel)]

Are you still seeing this bug? (sorry for the lateness of my reply, I am only just not seeing your comment)

Comment 11

[alberto.d.lopez501]

(In reply to Timothy Nikkel (:tnikkel) from comment #10)

Are you still seeing this bug? (sorry for the lateness of my reply, I am only just not seeing your comment)

Hello, I will try leaving multiple tabs open overnight and seeing if it causes the whole thing to crash, then I’ll report back to you!