1845446 - Support text decoration properties in highlight pseudo-elements

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

https://drafts.csswg.org/css-pseudo-4/#highlight-styling states that text-decoration and associated properties should be applied

It should help with css/css-pseudo/active-selection-014.html

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1845446 - CSS Highlight API: Implement support for `text-decoration`. r=#layout-reviewers!

This patch adds basic support for text-decoration in selection-based pseudo elements
(::selection, ::highlight(), ::target-text).
This is still missing support for text-decorations which are over- or underflowing.

Comment 3

[Jan Jaeschke [:jjaschke]]

The attached patch implements text-decoration for selection-based pseudos. However, ironically, it doesn't make the test mentioned in comment 0 pass. I think this misses https://www.w3.org/TR/css-pseudo-4/#paired-defaults. However, since I'm focusing on ::highlight, I would implement this in a follow-up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a723a587f01d
https://hg.mozilla.org/integration/autoland/rev/47dc7835a8f6
CSS Highlight API: Implement support for `text-decoration`. r=jfkthame,emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5505418e7642
https://hg.mozilla.org/integration/autoland/rev/8e2729719486
Revert "Bug 1845446 - CSS Highlight API: Implement support for `text-decoration`. r=jfkthame,emilio" for causing multiple Linux failures in Span.h.

Comment 6

[Serban Stanca [:SerbanS]]

Reverted this because it was causing multiple Linux failures in Span.h.

• Revert link
• Push with failures
• Failure Log
• Failure line: SUMMARY: AddressSanitizer: stack-use-after-scope /builds/worker/workspace/obj-build/dist/include/mozilla/Span.h:855:45 in data

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd3ccc448017
https://hg.mozilla.org/integration/autoland/rev/25ade20bace1
CSS Highlight API: Implement support for `text-decoration`. r=jfkthame,emilio

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/25ade20bace1