Closed Bug 1845521 Opened 2 years ago Closed 2 years ago

Permafailing OS X browser/components/sessionstore/test/browser_restoreLastClosedTabOrWindowOrSession.js | Got the expected number of tabs - x == x - {"filename":"chrome://mochitests/content/browser/browser/components/sessionstore/test/browser...

Categories

(Firefox :: Session Restore, defect, P5)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox115 --- unaffected
firefox116 --- unaffected
firefox117 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: sclements)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [retriggered])

Attachments

(1 file)

Bug 1845521 - Refactor browser_restoreLastClosedTabOrWindowOrSession test file r=#sessionstore-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=423914172&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EO5jxR81ShuAKf3g-pwung/runs/0/artifacts/public/logs/live_backing.log

[task 2023-07-26T12:30:25.873Z] 12:30:25     INFO - TEST-INFO | screencapture: exit 0
[task 2023-07-26T12:30:25.873Z] 12:30:25     INFO - Buffered messages logged at 12:30:25
[task 2023-07-26T12:30:25.873Z] 12:30:25     INFO - Entering test bound 
[task 2023-07-26T12:30:25.873Z] 12:30:25     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "data:text/html,<body><input>" line: 0}]
[task 2023-07-26T12:30:25.873Z] 12:30:25     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "data:text/html,<body><input>" line: 0}]
[task 2023-07-26T12:30:25.873Z] 12:30:25     INFO - Buffered messages finished
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_tabswitch_updatecommands.js | only one command update per tab switch - Got 2, expected 1
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - Stack trace:
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochikit/content/browser-test.js:test_is:1608
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabswitch_updatecommands.js:null:18
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - Update stack:
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - countUpdates@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabswitch_updatecommands.js:12:18
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - _adjustFocusBeforeTabSwitch@chrome://browser/content/tabbrowser.js:1393:34
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - updateDisplay@resource:///modules/AsyncTabSwitcher.sys.mjs:453:23
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - postActions@resource:///modules/AsyncTabSwitcher.sys.mjs:666:10
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1120:12
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - queueUnload@resource:///modules/AsyncTabSwitcher.sys.mjs:1057:10
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - requestTab@resource:///modules/AsyncTabSwitcher.sys.mjs:1053:10
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - updateCurrentBrowser@chrome://browser/content/tabbrowser.js:1099:31
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - _setupEventListeners/<@chrome://browser/content/tabbrowser.js:5885:16
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - set selectedIndex@chrome://global/content/elements/tabbox.js:236:14
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - set selectedPanel@chrome://global/content/elements/tabbox.js:246:54
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - set selectedIndex@chrome://global/content/elements/tabbox.js:599:9
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - set selectedItem@chrome://global/content/elements/tabbox.js:617:35
[task 2023-07-26T12:30:25.874Z] 12:30:25     INFO - set selectedTab@chrome://global/content/elements/tabbox.js:80:11
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedTab@chrome://browser/content/tabbrowser.js:355:7
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - switchTab@resource://testing-common/BrowserTestUtils.sys.mjs:393:7
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - @chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabswitch_updatecommands.js:16:26
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - 
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - Update stack:
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - countUpdates@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabswitch_updatecommands.js:12:18
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - _adjustFocusAfterTabSwitch@chrome://browser/content/tabbrowser.js:1537:10
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - updateDisplay@resource:///modules/AsyncTabSwitcher.sys.mjs:474:27
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - postActions@resource:///modules/AsyncTabSwitcher.sys.mjs:666:10
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1120:12
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - queueUnload@resource:///modules/AsyncTabSwitcher.sys.mjs:1057:10
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - requestTab@resource:///modules/AsyncTabSwitcher.sys.mjs:1053:10
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - updateCurrentBrowser@chrome://browser/content/tabbrowser.js:1099:31
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - _setupEventListeners/<@chrome://browser/content/tabbrowser.js:5885:16
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedIndex@chrome://global/content/elements/tabbox.js:236:14
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedPanel@chrome://global/content/elements/tabbox.js:246:54
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedIndex@chrome://global/content/elements/tabbox.js:599:9
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedItem@chrome://global/content/elements/tabbox.js:617:35
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedTab@chrome://global/content/elements/tabbox.js:80:11
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - set selectedTab@chrome://browser/content/tabbrowser.js:355:7
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - switchTab@resource://testing-common/BrowserTestUtils.sys.mjs:393:7
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - @chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabswitch_updatecommands.js:16:26
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - 
[task 2023-07-26T12:30:25.875Z] 12:30:25     INFO - Leaving test bound 
[task 2023-07-26T12:30:26.055Z] 12:30:26     INFO - GECKO(2178) | MEMORY STAT | vsize 419228MB | residentFast 661MB | heapAllocated 228MB
[task 2023-07-26T12:30:26.056Z] 12:30:26     INFO - TEST-OK | browser/base/content/test/tabs/browser_tabswitch_updatecommands.js | took 683ms

Hello Sarah! Could you please check this? It seems to permafail on OS X only and I think it's related with Bug 1845067 as it started somewhere in this area.

Thank you!

Keywords: regression
Regressed by: 1845067
Whiteboard: [retriggered]

Set release status flags based on info from the regressing bug 1845067

status-firefox115: --- → unaffected
status-firefox116: --- → unaffected
status-firefox117: --- → affected
status-firefox-esr102: --- → unaffected
status-firefox-esr115: --- → unaffected

Backfills and retriggers on Autoland confirm that this started with your changeset.

Assignee: nobody → sclements
Status: NEW → ASSIGNED

Something is strange with this failure on autoland at least. Here this is permafailing but on the next full push the test has passed as it can be seen here.

Hi Sarah! Do you think you can make a fix for this? I'm asking since the weekend will start soon, and the merge from central to beta will take place on Monday.

Maybe we should take into account a backout?

can't needinfo you Sarah - requests are blocked.

(In reply to Iulian Moraru from comment #4)

Something is strange with this failure on autoland at least. Here this is permafailing but on the next full push the test has passed as it can be seen here.

Hi Sarah! Do you think you can make a fix for this? I'm asking since the weekend will start soon, and the merge from central to beta will take place on Monday.

Maybe we should take into account a backout?

can't needinfo you Sarah - requests are blocked.

Oh, sorry, I must've forgotten to switch the needinfo off from my PTO! I have a patch now to put that test into a separate file which I'm hoping will solve the issue. I'm about to do a try push to ensure it looks okay in the platforms this is failing on. I'll try to get this merged to autoland this afternoon.

Also, if you'd rather back out the test feel free to do so - I can re-land test with the patch to put it in a separate test file. Would the fact that this test is for something that was uplifted to Beta have anything to do with the weird failures? I'd think not but figured I'd ask... The test was for the change in bug 1844791, I wasn't able to land it all at once since I ran out of time last Friday.

Flags: needinfo?(imoraru)

Code sheriffs can wait for the other patch to land today but this might only hide the issue. The incorrect number of tabs can either be explained by the new test or by the environment of the previously executed tests.

This is unrelated to the uplift of bug 1844791 to beta because the test in bug 1845067 only landed on central - beta is not affected.

Flags: needinfo?(imoraru)

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #6)

Code sheriffs can wait for the other patch to land today but this might only hide the issue. The incorrect number of tabs can either be explained by the new test or by the environment of the previously executed tests.

This is unrelated to the uplift of bug 1844791 to beta because the test in bug 1845067 only landed on central - beta is not affected.

I suspect it has to do with the test environment (see bug 1838996 where there's a similar issue with a test that is restoring tabs). It is odd that its only happening on certain versions of mac and not windows or linux. I can't reproduce it locally on my macbook which has an os version greater than 11 on it.

  • Split test_undo_last_action_correct_order into separate file
  • Clean all leftover tabs from test_reopen_last_tab_if_no_closed_actions
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5542f9618854 Refactor browser_restoreLastClosedTabOrWindowOrSession test file r=sessionstore-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/5542f9618854

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: