1845583 - Handle Keyboard shortcuts for edit and delete.

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P3)

Comment 1

[Sidharth Sachdev]

Attachment: Bug 1845583 - Handle Keyboard shortcuts for edit and delete. r=#credential-management-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535270e35c54
Handle Keyboard shortcuts for edit and delete. r=credential-management-reviewers,mtigley

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/535270e35c54

Comment 4

[Dianna Smith [:diannaS]]

:Sidharth is this something you want to mention in the fx120 release notes?
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 5

[Sidharth Sachdev]

Release Note Request (optional, but appreciated)
[Why is this notable]: Keyboard shortcuts that make it quicker for the user to perform edit and delete tasks on about:logins
[Affects Firefox for Android]: no
[Suggested wording]: Keyboard shortcuts added for editing and deleting a selected credential on about:logins. For editing - Alt+enter (Option+return on macOS) and for deleting - Alt+Backspace (Option+Delete on macOS).
[Links (documentation, blog post, etc)]:

Comment 6

[Dianna Smith [:diannaS]]

:Sidharth, should we mention what the shortcuts are? (are they different per platform?)
Also should we remove "copy" from the title if that is not implemented? (only because the relnote will link back to this ticket)

Comment 7

[Sidharth Sachdev]

(In reply to Dianna Smith [:diannaS] from comment #6)

:Sidharth, should we mention what the shortcuts are? (are they different per platform?)
Also should we remove "copy" from the title if that is not implemented? (only because the relnote will link back to this ticket)

Yup That's a good idea. I'll edit the comment with the note. Let me know if the changes look good.

Comment 8

[Dianna Smith [:diannaS]]

looks good, thanks! Added to Fx120 nightly notes https://www.mozilla.org/en-US/firefox/120.0a1/releasenotes/

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 121.0a1 (2023-10-31) and Firefox 120.0b4 on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04.