1845651 - Convert OpenMAX DL's assembler to clang compatible

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement)

Description

[Makoto Kato [:m_kato]]

Although I filed bug 1820455 to use MOZ_LIBAV_FFT even if arm32 build, performance isn't same as OpenMAX DL. I will convert OpenMAX DL's assembler to clang compatible

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1845651 - Part 1. Remove unused OpenMAX DL assembler files. r=padenot

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1845651 - Part 2. Convert OpenMAX DL assembler to clang compatible. r=padenot

Newer Android NDK has no GNU assembler, so I convert OpenMAX DL in Gecko to
clang compatible assembler.

Gecko's OpenMAX DL is imported from Cromium tree, but it is removed from
Chromium (https://crbug.com/917355). So there is no upstream code now.

Also, if using MOZ_LIBAV_FF on arm32 build, MOZ_LIBAV_FF is slower than
OpenMAX DL.

Convolution reverb - https://padenot.github.io/webaudio-benchmark/index.html

• OpenMAX DL ... 16x
• MOZ_LIBAV_FF ... 13x

Depends on D184717

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebd43acaeeb3
Part 1. Remove unused OpenMAX DL assembler files. r=padenot
https://hg.mozilla.org/integration/autoland/rev/84417d9a2abf
Part 2. Convert OpenMAX DL assembler to clang compatible. r=padenot

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ebd43acaeeb3
https://hg.mozilla.org/mozilla-central/rev/84417d9a2abf