1845695 - .catch() doesn't catch at _removeDistributionBookmarks in distribution.sys.mjs

Status: NEW

(Firefox :: Distributions, task)

Description

[Rob Wu [:robwu]]

There are two .catch() calls that give the mistaken impression of catching errors silently, at https://searchfox.org/mozilla-central/rev/00e6644d0db8acf9372702324151b8077a3d2bb7/browser/components/distribution.sys.mjs#111,116

That doesn't work because a .catch without function parameter doesn't actually catch an error. It is not clear whether this is an attempt to silence the error (in which case .catch(() => {}) could be used, or merely an attempt to avoid breaking the caller. In the latter case, .catch() can be removed altogether because the implementation of PlacesUtils.bookmarks.remove already wraps the call in try-catch (and doesn't await the result in the first place).