1845731 - Cache StyleRule desugaredSelectors

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Computing desugared selectors can be costly when dealing with deeply nested rule, so cache the result so we don't re-compute it when it's not needed

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1845731 - [devtools] Cache StyleRule desugared selectors. r=#devtools-reviewers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fdb9e7f3c3e
[devtools] Cache StyleRule desugared selectors. r=devtools-reviewers,jdescottes.

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9fdb9e7f3c3e

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9346063 [details]
Bug 1845731 - [devtools] Cache StyleRule desugared selectors. r=#devtools-reviewers.

Beta/Release Uplift Approval Request

• User impact if declined: very slow devtools performance on some pages
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): DevTools only fix, simple caching mechanism
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9346063 [details]
Bug 1845731 - [devtools] Cache StyleRule desugared selectors. r=#devtools-reviewers.

Approved for 117.0b6

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d84fc65ca98