1845780 - Instrument Rendering Performance

Status: NEW

(Firefox :: Firefox View, task, P3)

Description

[Stuart Colville [:muffinresearch]]

We'd like to track rendering perf in view. If there's nothing that implicitly covers this for us to understand this we should add telemetry for this explicitly.

Should be possible to understand this per "page".

Comment 1

[Sarah Clements [:sclements]]

I think we need some definition of what exactly we're going to measure and how (it might benefit from feedback from the perf team). Sam did you have anything specific in mind about what we'd do and how?

Comment 2

[Sam Foster [:sfoster] (he/him)]

I think a good start would be some markers in the start methods (or whatever equivalent) for each major component and after the first render with data. That would let us measure what I think is the most important time-elapsed between the user clicking to see something and having rendered that something.
We could get more fine-grained than that, but having those markers in the profiles would make it easy to zoom in and compare performance from one profile to another and seems like a good first step.

Comment 3

[Sam Foster [:sfoster] (he/him)]

For the how, I /think/ we can just use console.performance.mark(). But I only see a single instance of that in the tree, so maybe we're supposed to use ChromeUtils.addProfilerMarker().

Comment 4

[Markus Stange [:mstange]]

ChromeUtils.addProfilerMarker is probably the right call - Florian, can you expand on that?

Comment 5

[Florian Quèze [:florian]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

For the how, I /think/ we can just use console.performance.mark(). But I only see a single instance of that in the tree, so maybe we're supposed to use ChromeUtils.addProfilerMarker().

If your code has chrome privileges, you can indeed get better markers using ChromeUtils.addProfilerMarker().