1845783 - iframe is not translated

Status: NEW

(Firefox :: Translations, defect, P3)

Description

[Evgeny Pavlov]

Attachment: Screenshot 2023-07-27 at 9.57.15 AM.png

Example: https://yandex.ru/support/search/troubleshooting/feedback.html

See the screenshot.

This functionality works in Firefox Translations addon.

Comment 1

[Greg Tatum [:gregtatum]]

This functionality works in Firefox Translations addon.

Evgeny: Can you link to where this logic lives in the addon?

Comment 2

[Evgeny Pavlov]

It's a bit spread out, but there is this flag in mediator and we do things differently depending on whether it's a main frame or not. The extension scripts are loaded in both frames and they talk to each other through the background script: here is a diagram with the full sequence. You can also see the mentions of frameId in the bgScript to send the messages to the right frame. Id 0 is used to send them to the main frame. It's quite tricky and honestly I don't remember all the details.

Comment 3

[Greg Tatum [:gregtatum]]

The work for this would be to teach our JSActor system to work through iframes.

Details for the actors are here: https://firefox-source-docs.mozilla.org/dom/ipc/jsactors.html

We'll need to add allFrames: true to: https://searchfox.org/mozilla-central/source/toolkit/modules/ActorManagerParent.sys.mjs#487

This can be tested by adding an iframe example to similar to: https://searchfox.org/mozilla-central/rev/50588a0b728b365afdd298debd35e8302efe7850/toolkit/components/translations/tests/browser/translations-tester-es.html

Comment 6

[Greg Tatum [:gregtatum]]

Make sure and verify this fix against any closed duplicates above.

Comment 8

[Thomas Wisniewski [:twisniewski]]

Just FYI, Safari added support for translating iframes in 17.4 (as mentioned in the "Changes to Safari" section of the release notes).

Comment 9

[Marco Castelluccio [:marco]]

Pages such as https://www.ixsoft.de/ are also not translated (the page contains <frame> elements).