1845796 - Make entry and exit of screenshots explicit

Status: RESOLVED FIXED

(Firefox :: Screenshots, task, P2)

Description

[Sam Foster [:sfoster] (he/him)]

We have a couple of entry points and the initialization of Screenshots is reasonably clear. But exiting screenshots is not really the responsibility of any one method. We close the panel and sometimes that means we exit, but othertimes it means we're going to show the preview dialog. Same for the overlay.
For the keyboard accessibilty work, when we exit Screenshots I need to be able to attempt to restore focus to whatever was focused before we opened up the Screenshots UI. Tihs would be made much simpler by having an explicit exit method and more intentional sequence of tear down in place of the side-effects of various close/cancel methods.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r?niklas!

• Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
• Refactor to get rid of a bunch of implicit side-effects:
  • Separate out getting the panel from creating it
  • closePanel only closes the buttons panel
  • Add a closeOverlay so we do that and only that when needed
• When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
• Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a598817e740
Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1a598817e740