1845815 - Support binary response bodies in Viaduct

Status: RESOLVED FIXED

(Firefox :: Sync, task)

Description

[Drew Willcoxon :adw]

Firefox's Viaduct backend buffers response bodies in an nsCString and then passes them to response.set_body() without also passing in a length. That ends up treating all bodies as null-terminated strings, truncating them at the first null byte. Fortunately set_body() takes a second length arg ([1], [2]), and we only need to pass in the length to properly store all response bodies.

Despite the name, nsCString isn't a problem and we can continue to use it here because it does not assume its content is a null-terminated string as long as Append() is called with a length, as the Viaduct impl does.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1845815 - Support binary response bodies in Viaduct

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8f452645313
Support binary response bodies in Viaduct r=teshaq

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b8f452645313