1845830 - Chrome worker cld-worker.js never goes away for a plain text file Bugzilla attachment

Status: RESOLVED FIXED

(Firefox :: Translations, defect, P2)

Description

[Andrew McCreight [:mccr8]]

Steps to reproduce:

1. Open a plain text bugzilla attachment, like this one.

2. Wait for a few minutes.

3. Go to about:memory, and do measure. Look for the process for the text attachment (bug1754554.bmoattachments.org in this case).

The top memory consumer is the translation worker:

├──17.32 MB (47.31%) -- workers/workers(chrome)/worker(resource://gre/modules/translation/cld-worker.js, 0x11820eb00)

I have a different bugzilla attachment that appears to have been sitting in this state for hours. It seems bad to use up that much memory.

Maybe something weird is going on because the only document loaded into the process is a plain text file? This probably is not a common scenario outside of bugzilla where attachments are isolated into their own domains for security processes.

I've reproduced this issue with two different plain text bugzilla attachments.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gregtatum, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1845830 - Flush the worker after detecting a document language; r?nordzilla!

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

I'm not sure what severity to put for memory leaks, and this one goes away on tab close, so marking as S3.

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for fixing this! I have 6 of these workers going in my browser session right now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c22567ec4a3d
Flush the worker after detecting a document language; r=nordzilla

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c22567ec4a3d

Comment 7

[Greg Tatum [:gregtatum] (REO Fx132)]

Comment on attachment 9348918 [details]
Bug 1845830 - Flush the worker after detecting a document language; r?nordzilla!

Beta/Release Uplift Approval Request

• User impact if declined: When a language is detected in a tab for translations, a 17mb worker will be leaked until the tab is closed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a one line change to make sure the worker is scheduled for cleanup. The existing code is covered by tests.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348918 [details]
Bug 1845830 - Flush the worker after detecting a document language; r?nordzilla!

Approved for 117.0b9.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/33901ea7ca81