1845895 - Profile manager UI will break if a longer name is set for a new profile

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Found in

• Firefox 116.0

Affected versions

• Firefox 116.0
• Firefox 117.0a1

Tested platforms

• Affected platforms: macOS 13.5/14, Windows 11, Ubuntu 22.04

Steps to reproduce

1. Launch Firefox with profile manager
2. Select create profile
3. Select continue and at the profile name input a long name (any characters)
4. Click on Done

Expected result

• The profile manager window sill stretch around the length of the name

Actual result

• The profile manager window will get offset to the right of its screen and can't show the profile name properly

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the following attachment
• Reopening the profile manager after creating the longer named profile will have the window stretched to be able to properly show it.
• Maybe a character limit for names would help in avoiding this, or a dynamic stretch for the window.
• This was initially found with a RU build where the default name is longer for a profile.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:csasca, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f84b85f120f45fe6bad63d5e26b5ba4cd89f801&tochange=fd69d6b3aeb8e1e04334a0885f60966883a69c08

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1799460, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1845895 - Allow profile manager richlistbox to shrink. r=Gijs,dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6312f41e5223
Allow profile manager richlistbox to shrink. r=Gijs

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6312f41e5223

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9346253 [details]
Bug 1845895 - Allow profile manager richlistbox to shrink. r=Gijs,dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple / targeted CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9346253 [details]
Bug 1845895 - Allow profile manager richlistbox to shrink. r=Gijs,dao

Approved for 117.0b3.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0b0a11c9f1f3

Comment 11

[Daniel Bodea [:danibodea]]

This fix has been verified in today's Nightly v118.0a1. The Profile Manager no longer extends incorrectly when a profile name is longer than the window. It has been verified in Windows 10, Windows 11, Ubuntu 22 and MacOS 11. The fix will also be verified on Beta channel branch 117 when an official build is compiled, tomorrow.

Comment 12

[Daniel Bodea [:danibodea]]

Attachment: profile manager vs long usernames.png

I have, however, noticed that the Profile Manager window will behave differently between having created a very long profile name for the first time and opening it when there already is a profile with a very long username.

Detailed explanation: When the user opens the Profile Manager and creates a profile having a very long user name, the Profile Manager window will remain displayed with the initial smaller width window and show only a small portion of the username.
If then, the user opens the profile manager when there already is a profile with a very long username, the Profile Manager window will be displayed having a bigger width.

Is this behavior intended?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

It's a bit inconsistent but not too bad imo, if there's room for it we're sizing to content, which means we'll grow as needed... I haven't dug about what call ends up sizing the profile manager but that's in any case pre-existing.

Comment 14

[Daniel Bodea [:danibodea]]

Attachment: mac and linux password manager does not have a width limit.png

This fix has been verified in Beta v117.0b3. The Profile Manager no longer extends incorrectly when a profile name is longer than the window. It has been verified in Windows 10, Windows 11, Ubuntu 22 and MacOS 11. THank you.

I've noticed one more inconsistency between Windows and other OSes: Windows appears to have a maximum limit of width for the Password Manager window, but MacOS and Ubuntu stretch the window to show the complete username. This is not a regression. Is this an issue that should be addressed?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

I don't see any different styling so yeah might be worth tracking, though I don't have time right now to investigate it.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9346253 [details]
Bug 1845895 - Allow profile manager richlistbox to shrink. r=Gijs,dao

Approved for 115.2esr.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/91d79c26fd0e

Comment 18

[Anca Soncutean, Desktop QA]

Verified fixed with Fx 115.2esr on Windows 10, Ubuntu 22 and macOS 13.