Closed Bug 1845916 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41219 - Make room for page margins in web tests.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41219 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41219
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Make room for page margins in web tests.

With CL:4725066, page size calculation is done inside Blink, rather than
in PrintRenderFrameHelper & co. This makes it much easier to support web
tests properly, since we don't use PrintRenderFrameHelper in such cases
(and would otherwise have to duplicate its logic). For now, add support
for page margins. Later on, mixed page sizes will just work
out-of-the-box, once support for that has been added to the layout code
(upcoming CL).

Bug: 835358
Change-Id: Ic2b8b891b692d99f4d2d030a907399338abc96be
Reviewed-on: https://chromium-review.googlesource.com/4727864
WPT-Export-Revision: 7441389e61130469388bc3ffa223fa33809d1355

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by ctuns@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/5c3b89f5f3b6 [wpt PR 41219] - Make room for page margins in web tests., a=testonly https://hg.mozilla.org/mozilla-central/rev/98a629ec3982 [wpt PR 41219] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5c3b89f5f3b6
https://hg.mozilla.org/mozilla-central/rev/98a629ec3982

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.