1845936 - [wpt-sync] Sync PR 41224 - Printing: Add support for mixed page sizes.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41224 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41224
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Printing: Add support for mixed page sizes.

Although the printing code outside of Blink has supported mixed page
sizes for some time (in order to print PDFs with mixed page sizes, if
nothing else), the Blink layout engine lacked support for it, until now.

Document::GetPageDescription() had to be changed to accept a
ComputedStyle argument, rather than looking up the page name on its own.
Page names are determined during layout, so we cannot reliably look them
up during layout. NGPageLayoutAlgorithm will pass the page name to use,
via LayoutView::PageAreaSize(). Add a DCHECK to verify that layout is
complete before attempting to look up the page name for a given page
number. Some ancient test code that use GetPageDescription() is allowed
to call it before layout is finished. Make sure that we don't attempt to
look up page names in such cases.

Bug: 835358
Change-Id: I9d386a7ee08d784bd4573d5e66a1addd59158e62
Reviewed-on: https://chromium-review.googlesource.com/4729363
WPT-Export-Revision: 5859aad5e5a2a3b829dceed0c1d0a6c039cbc4fd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5185eeea793879930c6f6d2df3d6d9ee15cfa68

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 5 tests

Status Summary

Firefox

PASS: 1
FAIL: 4

Chrome

FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/printing/page-size-004-print.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/printing/page-size-005-print.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/printing/page-size-006-print.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/printing/page-size-008-print.html [wpt.fyi]: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/5040697650c1
[wpt PR 41224] - Printing: Add support for mixed page sizes., a=testonly
https://hg.mozilla.org/mozilla-central/rev/ba56fa61b9c6
[wpt PR 41224] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5040697650c1
https://hg.mozilla.org/mozilla-central/rev/ba56fa61b9c6