1846050 - The right-click menu is not wide enough. Ellipsis appears on the menu label.

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Alice0775 White]

Attachment: screenshot

[Tracking Requested - why for this release]:There is a problem with menu rendering.

Steps to reproduce:
0. Windows10 System font is changed to "MeiryoKe_UIGothic".

1. Right click on address bar

Actual results:
The right-click menu is not wide enough. Ellipsis appears on the menu label.
See attached screenshot.

Expected results:
No ellipsis should appear on the menu label.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5a3635bcdc01fb3d4b1d6e1d7410110c54a0fc2b&tochange=422af19ca706a86ef5b9a2ad0fa46e701b8a137d

Comment 1

[Alice0775 White]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1841612

:emilio, since you are the author of the regressor, bug 1841612, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Alice0775 White]

Attachment: screenshot2

When set system font to "Meiryo UI", see attached screenshot2 (context menu of new tab page body).

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1846050 - Ceil popup constraint sizes. r=dao,Gijs

So that we deal with subpixel values consistently / we don't introduce
accidental overflow.

I couldn't reproduce this locally tho, but the regressing bug could
potentially cause this, and given this is specific to our menupopup
frame behavior this seems ok. I could also ceil the constraint in
nsMenuPopupFrame instead, but being more explicit here makes sense imo.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1841612

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8df4f5c643bc
Ceil popup constraint sizes. r=Gijs

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8df4f5c643bc

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Alice, can you confirm this is fixed for you? I couldn't repro this on my Windows machine.

If so we should uplift.

Comment 10

[Alice0775 White]

I can reproduce this on Nightly118.0a1(20230802094513) Windows10.
And I verified fix this on Nightly118.0a1(20230802162859) Windows10.

Comment 11

[Donal Meehan [:dmeehan]]

(In reply to Alice0775 White from comment #10)

I can reproduce this on Nightly118.0a1(20230802094513) Windows10.
And I verified fix this on Nightly118.0a1(20230802162859) Windows10.

:emilio could you add a beta uplift request on this?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Beta patch.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1841612
[User impact if declined]: comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: comment 0 in theory, but couldn't repro locally on Windows 11.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not risky
[Why is the change risky/not risky?]: Tweaks subpixel rounding.
[String changes made/needed]: none

Comment 13

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9347907 [details] [diff] [review]
Beta patch.

Approved for 117.0b5

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2139e838f412

Comment 15

[Catalin Sasca, Desktop QA [:csasca]]

I was unable to reproduce the issue with the "MeiryoKe_UIGothic" set on Windows 10, while trying different resolutions and scalings (may be missing some further Windows settings in order to reproduce the issue).

Alice can you verify the fix on 117 as well? Thank you!

Comment 16

[Alice0775 White]

Yes,
I verified the fix on Firefox 117.0b5.