Treat "how to" as one word when matching prefixes for Pocket suggestions
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•2 years ago
|
||
STR for QA
- Set
browser.urlbar.pocket.featureGate= true to enable Pocket suggestions andbrowser.urlbar.bestMatch.enabled= true to enable best match - Type "how" and verify a low-confidence Pocket suggestion appears with the keyword "how scientists discovered helium" (It should not be a keyword that starts with "how to")
- Continue typing "how t" (no "o" at the end) and verify no suggestion appears whose keyword starts with "how to"
- Finish typing "how to" and verify a low-confidence suggestion appears with a keyword that starts with "how to"
These are all the low-confidence keywords that start with "how to". After you finish typing "how to", you should be able to trigger each of them by continuing to type them:
how to take a picture of the moon
how to enjoy being single
how to wash your face
how to be grateful
how to keep your cool
how to manage your anger at work
how to manage your anger (this one might not trigger since it starts with the same text as the previous one)
how to be happy when everyone else's life looks perfect
how to do market research
how to set business goals
how to experience yellowstone in every season
These are the high-confidence keywords that start with "how to". You should have to type each full keyword in order to trigger it, no prefix matching:
how to fix childcare
how to fix child care
how to get clearer skin
how to get clearer skin
how to recognize burnout
how to recover from burnout
how to prevent burnout
how to recognize burnout
how to regulate emotions
how to regulate emotions adults
how to process your feelings
how to feel your feelings
how to make friends as adults
how to make friends as an adult
how to make friends
how to make new friends
how to keep friends
how to maintain friendships
how to improve mental health
how to start a business
how to travel when it's so expensive
how to rewire habits
how to change habits
how to change my habits
how to break habits
how to break bad habits
how to manage zoom brain
|
|
Assignee | |
Comment 5•2 years ago
|
||
Comment on attachment 9346331 [details]
Bug 1846085 - Treat "how to" as one word when matching prefixes for Pocket suggestions.
Beta/Release Uplift Approval Request
- User impact if declined: This is required for the Pocket suggestions feature we intend to ship as an experiment in 117.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Please see previous comment
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small change that only affects Pocket suggestions in the urlbar, which are preffed off by default. Has a test.
- String changes made/needed:
- Is Android affected?: No
|
||
Updated•2 years ago
|
|
||
Comment 6•2 years ago
|
||
We verified this issue on the latest Firefox Nightly 118.0a1 (Build ID: 20230803094549) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.
- a low- confidence Pocket suggestion is displayed when typing “how” inside the Address Bar (for the "how scientists discovered helium" keyword);
- there is no Pocket suggestion displayed when typing the “how t” text in the Address Bar;
- a low- confidence Pocket suggestion is displayed when typing “how to” inside the Address Bar (for the "how to make a salad" keyword);
- the low-confidence keywords that start with “how to” are displayed when continuing to type the rest of the keyword
E.g.
“how to t” displays the result for the “how to talk to kids about climate change”
“how to take” displays the result for the “how to take a picture of the moon”
“how to e” displays the result for the “how to enjoy being single” etc.
- the high-confidence keywords that start with “how to” are displayed only when typing the complete keyword
E.g.
“how to fix childcare”
“how to recognize burnout”
“how to change habits” etc.
|
||
Comment 7•2 years ago
|
||
Comment on attachment 9346331 [details]
Bug 1846085 - Treat "how to" as one word when matching prefixes for Pocket suggestions.
Approved for 117.0b3.
|
|
||
Updated•2 years ago
|
|
|
||
Comment 9•2 years ago
|
||
We verified this issue on the latest Firefox Beta 117.0b3 (Build ID: 20230803180221) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.
- a low- confidence Pocket suggestion is displayed when typing “how” inside the Address Bar (for the "how scientists discovered helium" keyword);
- there is no Pocket suggestion displayed when typing the “how t” text in the Address Bar;
- a low- confidence Pocket suggestion is displayed when typing “how to” inside the Address Bar (for the "how to make a salad" keyword);
- the low-confidence keywords that start with “how to” are displayed when continuing to type the rest of the keyword
E.g.
“how to t” displays the result for the “how to talk to kids about climate change”
“how to take” displays the result for the “how to take a picture of the moon”
“how to e” displays the result for the “how to enjoy being single” etc.
- the high-confidence keywords that start with “how to” are displayed only when typing the complete keyword
E.g.
“how to fix childcare”
“how to recognize burnout”
“how to change habits” etc.
Description
•