1846223 - sccache-dist failure with error: failed to open file third_party/rust/error-support/Cargo.toml due to uniffi::include_scaffolding!("glean")

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect, P1)

Description

[:gerard-majax]

 0:09.71 error: failed to open file `/home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/error-support/Cargo.toml`
 0:09.71    --> /home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/error-support/src/lib.rs:162:1
 0:09.71     |
 0:09.71 162 | uniffi::include_scaffolding!("errorsupport");
 0:09.71     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:09.71     |
 0:09.71     = note: this error originates in the macro `uniffi::include_scaffolding` (in Nightly builds, run with -Z macro-backtrace for more info)
 0:09.71 note: erroneous constant used
 0:09.71    --> /home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/error-support/src/lib.rs:162:1
 0:09.71     |
 0:09.71 162 | uniffi::include_scaffolding!("errorsupport");
 0:09.71     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:09.71     |
 0:09.71     = note: this note originates in the macro `uniffi::include_scaffolding` (in Nightly builds, run with -Z macro-backtrace for more info)
 0:09.71 sccache: Compiler killed by signal 1
 0:09.71 error: could not compile `error-support` due to previous error
 0:09.71 Caused by:
 0:09.71   process didn't exit successfully: `/home/alex/codaz/Mozilla/sccache/target/release/sccache /home/alex/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc --crate-name error_support --edition=2021 /home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/error-support/src/lib.rs --error-format=json --json=diagnostic-ren
dered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C debug-assertions=on -C metadata=c65501e5aa5afc9b -C extra-filename=-c65501e5aa5afc9b --out-dir /home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps
--target x86_64-unknown-linux-gnu -C linker=/home/alex/codaz/Mozilla/gecko-cinnabar/build/cargo-linker -L dependency=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps -L dependency=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/debug/deps --extern error_support_macros=/home/alex/codaz/Mo
zilla/gecko-cinnabar/obj-browser-dbg/debug/deps/liberror_support_macros-31d34d0b886b254d.so --extern lazy_static=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/liblazy_static-e75e842cb90ee29b.rmeta --extern log=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/de
bug/deps/liblog-e9d4752019f925f5.rmeta --extern parking_lot=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-67d8bc657c73e131.rmeta --extern uniffi=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libuniffi-3d32c1c5406f89c4.rmeta --cap-li
nts allow -C debuginfo=2 -C force-frame-pointers=yes --cap-lints warn -Clto=off` (exit status: 254)
 0:09.71 warning: build failed, waiting for other jobs to finish...
 0:10.99 error: failed to open file `/home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/glean-core/Cargo.toml`
 0:11.00     --> /home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/glean-core/src/lib.rs:1136:5
 0:11.00      |
 0:11.00 1136 |     uniffi::include_scaffolding!("glean");
 0:11.00      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:11.00      |
 0:11.00      = note: this error originates in the macro `uniffi::include_scaffolding` (in Nightly builds, run with -Z macro-backtrace for more info)
 0:11.00 note: erroneous constant used
 0:11.00     --> /home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/glean-core/src/lib.rs:1136:5
 0:11.00      |
 0:11.00 1136 |     uniffi::include_scaffolding!("glean");
 0:11.00      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:11.00      |
 0:11.00      = note: this note originates in the macro `uniffi::include_scaffolding` (in Nightly builds, run with -Z macro-backtrace for more info)
 0:11.00 sccache: Compiler killed by signal 1
 0:11.00 error: could not compile `glean-core` due to previous error
 0:11.00 Caused by:
 0:11.00   process didn't exit successfully: `/home/alex/codaz/Mozilla/sccache/target/release/sccache /home/alex/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc --crate-name glean_core --edition=2021 /home/alex/codaz/Mozilla/gecko-cinnabar/third_party/rust/glean-core/src/lib.rs --error-format=json --json=diagnostic-rendered-
ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C debug-assertions=on --cfg 'feature="preinit_million_queue"' -C metadata=de6c859d0e0fa087 -C extra-filename=-de6c859d0e0fa087 --out-dir /home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x8
6_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/home/alex/codaz/Mozilla/gecko-cinnabar/build/cargo-linker -L dependency=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps -L dependency=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/debug/deps --extern bincod
e=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libbincode-ee6aff6e184367c5.rmeta --extern chrono=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libchrono-6a40d7884def0c6c.rmeta --extern crossbeam_channel=/home/alex/codaz/Mozilla/gecko-cinnabar/obj
-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libcrossbeam_channel-a77aeafd4fd45e5c.rmeta --extern flate2=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libflate2-b78b97e9376aa8e6.rmeta --extern log=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/
liblog-e9d4752019f925f5.rmeta --extern once_cell=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libonce_cell-f19b32376b05f724.rmeta --extern rkv=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/librkv-c3f52c096735b36c.rmeta --extern serde=/home/alex/c
odaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libserde-62852348b9c45ac9.rmeta --extern serde_json=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libserde_json-903ac9daa2b805b9.rmeta --extern thiserror=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86
_64-unknown-linux-gnu/debug/deps/libthiserror-9bb2113f7c77916f.rmeta --extern time=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libtime-eb8a554a9f1a5bf3.rmeta --extern uniffi=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libuniffi-3d32c1c5406f89c
4.rmeta --extern uuid=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libuuid-d32b787b69ebc85f.rmeta --extern zeitstempel=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/deps/libzeitstempel-8f2eb5008d586665.rmeta --cap-lints allow -C debuginfo=2 -C force-f
rame-pointers=yes --cap-lints warn -Clto=off -L native=/home/alex/codaz/Mozilla/gecko-cinnabar/obj-browser-dbg/x86_64-unknown-linux-gnu/debug/build/lmdb-rkv-sys-bb847ef5d99655bf/out` (exit status: 254)

Likely sccache-dist does not sent some files or we should do the compile locally

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:janerik, since you are the author of the regressor, bug 1840044, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[:gerard-majax]

Attachment: quick hack

This quick hack at least unblocks me

Comment 3

[Jan-Erik Rediger [:janerik]]

So far I have not been able to reproduce it in my local setup using sccache.
I do however understand what is happening and I'm trying to figure out how to best address it.

Comment 4

[Jan-Erik Rediger [:janerik]]

After fixing my sccache setup I'm now able to reproduce this, which will make it easier to test out a fix at least.

Comment 5

[Jan-Erik Rediger [:janerik]]

Attachment: pr 1682: Bug 1846223 - uniffi_macros: Force-include the Cargo.toml to read

Comment 6

[Jan-Erik Rediger [:janerik]]

Attachment: pr 1683: Bug 1846223 - uniffi_macros: Force-include the Cargo.toml to read [v0.24 patch]

Comment 7

[Jan-Erik Rediger [:janerik]]

badboy merged PR #1683: "Bug 1846223 - uniffi_macros: Force-include the Cargo.toml to read [v0.24 patch]" in 6344ff7.

Comment 8

[Jan-Erik Rediger [:janerik]]

badboy merged PR #1682: "Bug 1846223 - uniffi_macros: Force-include the Cargo.toml to read" in 8b0563c.

Comment 9

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1846223 - Update to uniffi 0.24.3 r?TravisLong

Includes a bug fix for sccache-dist builds

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1840044

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbb159d622fd
Update to uniffi 0.24.3 r=TravisLong,supply-chain-reviewers

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fbb159d622fd

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:janerik, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Jan-Erik Rediger [:janerik]]

Comment on attachment 9346664 [details]
Bug 1846223 - Update to uniffi 0.24.3 r?TravisLong

Beta/Release Uplift Approval Request

• User impact if declined: None. This is a developer-only fix.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The dependency update only fixes an issue for local builds using sccache-dist.
  The final code is unaffected.
• String changes made/needed:
• Is Android affected?: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9346664 [details]
Bug 1846223 - Update to uniffi 0.24.3 r?TravisLong

Approved for 117.0b3.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/38b5901830d1