1846243 - Open Tabs should not be affected when a user changes privacy setting to "Never remember history"

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2023-07-31_13h36_31.png

Affected versions

• Nightly 117.0a1

Affected platforms

• Windows 10x64, macOS 13 and Ubuntu

Steps to reproduce

1. Go to about:config and flip browser.tabs.firefox-view-next to true
2. Go to about:preferences#privacy and set History to "Never remeber" or Use custom settings with Always use private browsing mode checked
3. Open Firefox View Next tab with Recent Browsing page focused
4. Observe the Open tabs

Expected result

• Open Tabs has View All link when setting history to "Never remember history"/"Use custom" with Always use private browsing

Actual result

• Open Tabs View All links shouldn't be displayed when user sets history to "Never remember history"/"Use custom" with Always use private browsing

Regression range

• New feature

Additional notes

• See attached screenshot

Comment 1

[Sarah Clements [:sclements]]

Hi Gabi, I'm trying to understand what the bug is here. Open tabs are just the tabs you have open within any window and it doesn't have anything to do with history or private browsing settings, unlike recently closed tabs which does. Can you clarify please?

Comment 2

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Sarah Clements [:sclements] from comment #1)

Hi Gabi, I'm trying to understand what the bug is here. Open tabs are just the tabs you have open within any window and it doesn't have anything to do with history or private browsing settings, unlike recently closed tabs which does. Can you clarify please?

Hi Sarah, "View All" link is displayed for the empty Open tabs page, not sure if this is intended as the opened tabs are not listed in the Firefox View when the browser is set to "Never remember history".
I'm attaching a gif describing the issue. Let me know if further details are needed.

Comment 3

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2023-08-10_opentabs.gif

Comment 4

[Sarah Clements [:sclements]]

Thanks Gabi, I'm able to reproduce.

Comment 5

[Mike Kaply [:mkaply]]

I'm updating it so that private windows only show open tabs for their own window.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Bug 1846243 - Private windows should only have their own tabs in open tabs. r?jsudiaman

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7643e2c34ec4
Private windows should only have their own tabs in open tabs. r=jsudiaman,fxview-reviewers,kcochrane

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/7643e2c34ec4

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 117.0a1 (2023-07-28) on MacOS 12 ARM.
The issue is verified fixed with Firefox 120.0a1 (20231004155628) and Firefox 119.0b5 (20231004091611) on MacOS 12 ARM, Win 10 and Ubuntu 22.04.