Closed Bug 1846251 Opened 4 months ago Closed 4 months ago

[css-nesting] Make CSSStyleRule a CSSGroupingRule

Categories

(Core :: DOM: CSS Object Model, defect)

defect

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.

As per https://github.com/w3c/csswg-drafts/issues/8940.

I didn't do this in bug 1837638 because that's what the spec said at the
time, that's what other browsers did, and specially because if we did
this we had no way of runtime-disable nesting during development or if
things went south.

This means that we can't keep the nesting pref in 118, but that seems
fine (it's already enabled everywhere in 117).

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/085c31f150d3
Make CSSStyleRule inherit from CSSGroupingRule. r=peterv,devtools-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41248 for changes under testing/web-platform/tests

Backed out for causing CSSStyleRule related wpt failures.

[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO - TEST-PASS | /css/cssom/idlharness.html | CSSRule interface: constant NAMESPACE_RULE on interface prototype object 
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO - TEST-UNEXPECTED-FAIL | /css/cssom/idlharness.html | CSSStyleRule interface: existence and properties of interface object - assert_equals: prototype of CSSStyleRule is not CSSRule expected function "function CSSRule() {
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO -     [native code]
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO - }" but got function "function CSSGroupingRule() {
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO -     [native code]
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO - }"
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO - IdlInterface.prototype.test_self/<@http://web-platform.test:8000/resources/idlharness.js:1516:30
[task 2023-07-31T22:35:09.887Z] 22:35:09     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - self.subsetTestByKey@http://web-platform.test:8000/resources/idlharness.js:44:14
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - IdlInterface.prototype.test_self@http://web-platform.test:8000/resources/idlharness.js:1453:20
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:1433:14
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:748:28
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - idl_test/</<@http://web-platform.test:8000/resources/idlharness.js:3529:31
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - 
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - TEST-PASS | /css/cssom/idlharness.html | CSSStyleRule interface object length 
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - TEST-PASS | /css/cssom/idlharness.html | CSSStyleRule interface object name 
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - TEST-UNEXPECTED-FAIL | /css/cssom/idlharness.html | CSSStyleRule interface: existence and properties of interface prototype object - assert_equals: prototype of CSSStyleRule.prototype is not CSSRule.prototype expected object "[object CSSRule]" but got object "[object CSSGroupingRule]"
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - IdlInterface.prototype.test_self/<@http://web-platform.test:8000/resources/idlharness.js:1845:30
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-31T22:35:09.888Z] 22:35:09     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-31T22:35:09.889Z] 22:35:09     INFO - self.subsetTestByKey@http://web-platform.test:8000/resources/idlharness.js:44:14
[task 2023-07-31T22:35:09.889Z] 22:35:09     INFO - IdlInterface.prototype.test_self@http://web-platform.test:8000/resources/idlharness.js:1761:20
[task 2023-07-31T22:35:09.889Z] 22:35:09     INFO - IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:1433:14
[task 2023-07-31T22:35:09.889Z] 22:35:09     INFO - IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:748:28
[task 2023-07-31T22:35:09.889Z] 22:35:09     INFO - idl_test/</<@http://web-platform.test:8000/resources/idlharness.js:3529:31
[task 2023-07-31T22:35:10.023Z] 22:35:10     INFO - .....................................................................................................................................................................................................................................................................................
[task 2023-07-31T22:35:10.023Z] 22:35:10     INFO - TEST-OK | /css/cssom/idlharness.html | took 3414ms
Flags: needinfo?(emilio)
Upstream PR was closed without merging
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62534bac9235
Make CSSStyleRule inherit from CSSGroupingRule. r=peterv,devtools-reviewers
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Upstream PR merged by moz-wptsync-bot

== Change summary for alert #39205 (as of Thu, 03 Aug 2023 01:55:56 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
18% damp custom.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 750.10 -> 881.42
17% damp custom.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 767.34 -> 897.32
13% damp custom.styleeditor.open.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 620.02 -> 701.28
12% damp custom.styleeditor.open.DAMP windows10-64-shippable-qr e10s fission stylo webrender 628.97 -> 705.52

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39205

Regressions: 1847565
Keywords: dev-doc-needed

FF118 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/28853 (work fairly minimal and effectively complete).

You need to log in before you can comment on or make changes to this bug.