1846255 - Tab key navigation does not work for Show more button Open tabs

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Affected versions

• Nightly 117.0a1

Affected platforms

• Windows 10x64, Ubuntu 18.4, macOS 13

Steps to reproduce

1. Launch Firefox and focus the Open tabs page in Firefox View Next
2. Open a few new windows with different websites loaded in tabs
3. Using the Tab key navigate the Open tabs page to reach the View more link at the bottom of the window card

Expected result

• Tab key navigation to Show more link should be possible

Actual result

• Tab key navigation does not work for Show more button Open tabs

Regression range

• New implementation

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/798de3f71896
Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing OSX mochitests failures in test_opentabs.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/chrome/test_opentabs.html | Test timed out. -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40053facf08c
Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/40053facf08c

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 117.0a1 (2023-07-26) on Win 10.
The issue is verified fixed with Firefox 120.0a1 (20231005212657) and Firefox 119.0b5 (20231004091611) on MacOS 12 ARM, Win 10 and Ubuntu 22.04.