1846284 - [Sidebar] Create text component with links

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Negin Sauermann]

Scope of this ticket is to implement component that displays paragraph with up to 3 links. This will be used to display body copy block and legal copy section in opt-in UI in 1847641. This element should be flexible enough to appear above the button group or below the button group. This element should be flexible enough to include 1, 2, or 3 links to seperate URLs. (For example, to accommodate a link to a privacy policy, a terms of use, and a learn more (support article) link as needed.)

https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Shopping-Experience-MVP?type=design&node-id=2599-83032&mode=design&t=zDGkvv89e1iCjk2a-4

Text should show correct as per designs in HCM, Dark theme, RTL (pref intl.l10n.pseudo as ‘bidi’ ) and (pref intl.l10n.pseudo as 'accented' ) accented format.

Comment 1

[Negin Sauermann]

Attachment: Bug 1846284 - [Sidebar] Create text component with links

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49d2e361b23a
[Sidebar] Create text component with links r=omc-reviewers,fluent-reviewers,flod,aminomancer

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for newtab failure

Backout link: https://hg.mozilla.org/integration/autoland/rev/20881b38639c4e3f99b6114e4ccb947ee9f98256
Log link: https://treeherder.mozilla.org/logviewer?job_id=425556739&repo=autoland&lineNumber=67

Comment 4

[Negin Sauermann]

Sorry about that - looks like my bundle file was out of date and needed to add a bit more test coverage.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/753de3b5d641
[Sidebar] Create text component with links r=omc-reviewers,fluent-reviewers,flod,aminomancer

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/753de3b5d641

Comment 7

[Rares Doghi, Desktop QA]

Hi @Negin this task implements the ability to add up to 3 links for the Onboarding Fakespot sidebar, does this mean that the "Learn more" link should also be displayed there ? or is it something that will be implemented later on ? so far we only have the 2 links "Privacy Policy" and "Terms of use".

Comment 8

[Negin Sauermann]

Hi Rares! Thanks for asking - this would be handled in another component which will render multiple paragraphs with or without links based on the configuration of this patch. This patch specifically covers the "Legal copy" section found in Figma where we can configure as many links as possible within that section (currently it's configured for two links but this can be configured to handle more). Sorry for the lack of clarity with the initial bug description - let me know if you have any other questions.

Comment 9

[Rares Doghi, Desktop QA]

Nope, Thanks a lot, I will update the Flags for this issue. Verified as fixed in our latest Nightly build.