1846291 - There is a size inconsistency between history/bookmarked/switch to tab and suggestion results favicons

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: pocket favicons difference.jpg

[Affected versions]:

• Firefox Nightly 117.0a1 - Build ID: 20230730210800
• Firefox RC 116 - Build ID: 20230724170120

[Affected Platforms]:

• Windows 10 x64
• Linux Ubuntu 20.04 x64
• macOS 12.6.1

[Prerequisites]:

• Set browser.urlbar.pocket.featureGate to “true”.
• Set browser.urlbar.bestMatch.enabled to “true”.
• Set browser.search.region to “US”.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Type “breakfast” in the Address Bar.
3. Click the “Cat Cora” Pocket suggestion.
4. Open a new tab and type “breakfast” in the Address Bar.
5. Observe the favicons of the results displayed in the Firefox Suggest section.

[Expected result]:

• Both Pocket favicons are the same size.

[Actual result]:

• The Pocket favicon of the “Switch to tab” result is bigger than the Pocket suggestion’s favicon.

[Notes]:

• Attached is a screenshot of the issue.

Comment 1

[Drew Willcoxon :adw]

Great catch, thanks! Looks bad. I'll bump it down to S4 since it's purely a visual problem.

Comment 2

[Drew Willcoxon :adw]

The chevron stroke inside the svg is thinner than the one in the favicon too. We should just use the favicon when showing this icon at 16px.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1846291 - Use Pocket favicon when showing Pocket suggestions at 16px.

Please see the bug for context. For pixel-perfect accuracy, we should just use
the favicon when showing the icon at 16px. We can continue to use the svg when
showing it at the larger best-match size.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4fd93143fa0
Use Pocket favicon when showing Pocket suggestions at 16px. r=dao

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9347478 [details]
Bug 1846291 - Use Pocket favicon when showing Pocket suggestions at 16px.

Beta/Release Uplift Approval Request

• User impact if declined: This is necessary for the Pocket suggestions experiment that targets 117.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from the comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is purely a visual change that replaces one icon with another. The test coverage makes sure we use the appropriate icon.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f4fd93143fa0

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

We verified this issue on the latest Firefox Nightly 118.0a1 (Build ID: 20230809092330) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Pocket favicons from the Pocket suggestions and the history/bookmark/switch to tab results are looking the same when the results are triggered in the Firefox Suggest section.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9347478 [details]
Bug 1846291 - Use Pocket favicon when showing Pocket suggestions at 16px.

Approved for 117.0b6

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/77ec193cc3ef

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

We verified this issue on the latest Firefox Beta 117.0b6 (Build ID: 20230810181819) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Pocket favicons from the Pocket suggestions and the history/bookmark/switch to tab results are looking the same when the results are triggered in the Firefox Suggest section.