1846347 - Tab syncing broken on Nightlies

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

No tabs will be uploaded from Nightlies since bug 1840044 landed. That bug is only indirectly responsible though - it's the new application-services which caused the regression. The fix will be another update to app-services.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1846347 - update application-services to fix tab syncing. r?skhamis

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea7df1f8976b
update application-services to fix tab syncing. r=skhamis

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ea7df1f8976b

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:markh, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 9346568 [details]
Bug 1846347 - update application-services to fix tab syncing. r?skhamis

Beta/Release Uplift Approval Request

• User impact if declined: Tab syncing is broken
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Limited to tab syncing
• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9346568 [details]
Bug 1846347 - update application-services to fix tab syncing. r?skhamis

Approved for 117.0b3.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e176d99d1843

Comment 8

[Maria Berlinger [:mberlinger], Services QA]

Attachment: sync issue.png

Hello,
We have tried to reproduce this issue on Nightly 117.0a1 (2023-07-30).
We have logged with the same FxA account on 2 different nightly profiles.
On the first profile the tabs opened on the second profile are displayed in the Sidebar > Synced tabs option. On the second profile the tabs opened on the first profile are not displayed in the Sidebar > Synced tabs option.

Could you please let us know if this was the initial issue?

Thank you!

Comment 9

[Maria Berlinger [:mberlinger], Services QA]

Hello,

We have investigated more today and figured out the behavior on affected Nightly (117.0a1 (2023-07-30)) and beta (117.0b2 ) builds.
The issue is verified as fixed using latest Nightly build 118.0a1 (2023-08-10) and on Beta 117.0b3 the tab syncing is now working.