Closed Bug 1846392 Opened 1 year ago Closed 1 year ago

Rewrite JS shell off-thread compilation/decode functions with JS::FrontendContext and its own thread

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(2 files)

After bug 1837964, bug 1845638, and bug 1846380, JS shell is the only consumer of off-thread compilation and decode APIs.
I order to remove the ParseTask, and also to reflect the actual usage, JS shell should use JS::FrontendContext-based APIs, with their own thread handling, separate from helper threads.

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Blocks: 1846194
Attachment #9346735 - Attachment description: WIP: Bug 1846392 - Rewrite JS shell off-thread compilation/decode functions with JS::FrontendContext and its own thread. r?nbp! → Bug 1846392 - Rewrite JS shell off-thread compilation/decode functions with JS::FrontendContext and its own thread. r?nbp!
Attachment #9346735 - Attachment description: Bug 1846392 - Rewrite JS shell off-thread compilation/decode functions with JS::FrontendContext and its own thread. r?nbp! → Bug 1846392 - Part 1: Rewrite JS shell off-thread compilation/decode functions with JS::FrontendContext and its own thread. r?nbp!

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(nicolas.b.pierron)
Flags: needinfo?(arai.unmht)

I'll land these patches in the next cycle

Flags: needinfo?(nicolas.b.pierron)
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/dc1e82532e0a
Part 1: Rewrite JS shell off-thread compilation/decode functions with JS::FrontendContext and its own thread. r=nbp
https://hg.mozilla.org/integration/autoland/rev/284aef199efe
Part 2: Stop using JS::CanCompileOffThread and JS::CanDecodeOffThread in JS shell. r=nbp
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: