Closed Bug 1846394 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41266 - FSA: Use IDL-generated string constants for WellKnownDirectory

Tracking

(firefox118 fixed)

Status:

RESOLVED FIXED

Milestone:

118 Branch

Tracking Flags:

Tracking

Status

firefox118

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

1 year ago

Sync web-platform-tests PR 41266 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41266
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

FSA: Use IDL-generated string constants for WellKnownDirectory

Follow-up to https://crrev.com/c/4727474 which addresses use of the
WellKnownDirectory enum. Also refectors the mojom interface to simplify
the file picker options passed over mojo

By removing the kDefault option from the WellKnownDirectory mojom enum,
it now matches its counterpart defined in web IDL

This should result in a small decrease in binary size and protect
against (web-exposed!) typos

Change-Id: I84d513a621b0f55cabff12d95c4037a93adc27ee
Reviewed-on: https://chromium-review.googlesource.com/4736693
WPT-Export-Revision: ff253b2b7d5b2f063853fa22e45d336c58a6bba6

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 year ago

Whiteboard: [wptsync downstream] → [wptsync downstream error]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 year ago

Whiteboard: [wptsync downstream error] → [wptsync downstream]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

1 year ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c5acd6408e33a065fb72ebbe5ba76fa105704cd

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

1 year ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 71 subtests

Status Summary

Firefox

OK : 1
FAIL: 71

Chrome

OK : 1
PASS: 71

Safari

OK : 1
FAIL: 71

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/showPicker-errors.https.window.html [wpt.fyi]
- showOpenFilePicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
- showDirectoryPicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: File picker requires at least one accepted type.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't be an empty string.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type must have subtype.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't have empty type.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't have empty subtype.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't have parameters.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't have invalid characters in type.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't have whitespace in the middle.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: MIME type can't have invalid characters in subtype.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: unknown well-known starting directory.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: starting directory can be empty.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: starting directory can be null.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: starting directory ID contains invalid characters.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: starting directory ID cannot exceed 32 characters.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".extensiontoolong". extension length more than 16..: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt.". extenstion ends with ".".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension "txt". extenstion does not start with ".".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".$txt". illegal character "$".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".t<xt". illegal character "<".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".t/xt". illegal character "".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ". xt". illegal character "/".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt". illegal characters "".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt?". illegal character "?".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt*". illegal character "*".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".{txt". illegal character "{".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".}txt". illegal character "}".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension " .txt". illegal whitespace at front of extension.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ". txt". illegal whitespace in extension.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt ". illegal whitespace at end of extension.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt". illegal RTL character.: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".tæxt". non-ASCII character "æ".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".קום". non-ASCII character "קום".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".txt🙂". non-ASCII character "🙂".: FAIL (Chrome: PASS, Safari: FAIL)
- showOpenFilePicker: invalid extension ".{txt}". illegal characters "{" and "}".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: File picker requires at least one accepted type.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't be an empty string.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type must have subtype.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't have empty type.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't have empty subtype.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't have parameters.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't have invalid characters in type.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't have whitespace in the middle.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: MIME type can't have invalid characters in subtype.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: unknown well-known starting directory.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: starting directory can be empty.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: starting directory can be null.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: starting directory ID contains invalid characters.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: starting directory ID cannot exceed 32 characters.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".extensiontoolong". extension length more than 16..: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt.". extenstion ends with ".".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension "txt". extenstion does not start with ".".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".$txt". illegal character "$".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".t<xt". illegal character "<".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".t/xt". illegal character "".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ". xt". illegal character "/".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt". illegal characters "".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt?". illegal character "?".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt*". illegal character "*".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".{txt". illegal character "{".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".}txt". illegal character "}".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension " .txt". illegal whitespace at front of extension.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ". txt". illegal whitespace in extension.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt ". illegal whitespace at end of extension.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt". illegal RTL character.: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".tæxt". non-ASCII character "æ".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".קום". non-ASCII character "קום".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".txt🙂". non-ASCII character "🙂".: FAIL (Chrome: PASS, Safari: FAIL)
- showSaveFilePicker: invalid extension ".{txt}". illegal characters "{" and "}".: FAIL (Chrome: PASS, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 year ago

Depends on: 1848676

Pulsebot

Comment 3

•

1 year ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19da4b8eccb1 [wpt PR 41266] - FSA: Use IDL-generated string constants for WellKnownDirectory, a=testonly https://hg.mozilla.org/integration/autoland/rev/e357802079cf [wpt PR 41266] - Update wpt metadata, a=testonly

Serban Stanca [:SerbanS]

Comment 4

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/19da4b8eccb1
https://hg.mozilla.org/mozilla-central/rev/e357802079cf

Status: NEW → RESOLVED

Closed: 1 year ago

status-firefox118: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 118 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

[wpt-sync] Sync PR 41266 - FSA: Use IDL-generated string constants for WellKnownDirectory

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox118 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 3

Comment 4