1846461 - Move QueryFolderChildren, QueryFolderChildrenAsync, ProcessFolderNodeRow to nsNavHistoryResult

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

These methods are only used by nsNavHistoryResult so it doesn't make sense to have them in the Bookmarks service.
Long term (after tags are converted) the Bookmarks service should be merged into renamed nsNavHistory anyway.

Methods that need a db connection can be moved into nsNavHistory, others into nsNavHistoryResult... we can eval.

Code renames/cleanups are welcome while doing this.

Comment 1

[Marco Bonardo [:mak]]

Moving ResultNodeForContainer to nsNavHistory would also be fine, along with the GUID version of FetchItemInfo() that is only used there.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1846461: Move logic that appends children of folder to nsNavHistoryResult

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1846461: Remove FetchItemInfo(guid) from nsNavBookmarks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e236d89e7054
https://hg.mozilla.org/integration/autoland/rev/73b9fba031a3
Move logic that appends children of folder to nsNavHistoryResult r=places-reviewers,mak
https://github.com/mozilla-firefox/firefox/commit/c7e28148ef9b
https://hg.mozilla.org/integration/autoland/rev/51858ce9b8ab
Remove FetchItemInfo(guid) from nsNavBookmarks r=places-reviewers,mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa539356e80f
https://hg.mozilla.org/integration/autoland/rev/66896bac6f53
Revert "Bug 1846461: Remove FetchItemInfo(guid) from nsNavBookmarks r=places-reviewers,mak" for causing build bustages @ nsNavHistoryResult.h

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ nsNavHistoryResult.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/66896bac6f53507286c0570972fe6815969e2973

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.h:821:29: error: unknown type name 'mozIStorageValueArray'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/583e83c688f1
https://hg.mozilla.org/mozilla-central/rev/3d4495d84d36
Move logic that appends children of folder to nsNavHistoryResult r=places-reviewers,mak
https://github.com/mozilla-firefox/firefox/commit/2cbee83350a3
https://hg.mozilla.org/mozilla-central/rev/4ec20930648c
Remove FetchItemInfo(guid) from nsNavBookmarks r=places-reviewers,mak

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3d4495d84d36
https://hg.mozilla.org/mozilla-central/rev/4ec20930648c