1846473 - Enable the `inverted-colors` media query

Status: NEW

(Core :: CSS Parsing and Computation, task)

Description

[Luke Warlow]

Firefox has implemented the inverted-colors media query behind its own pref (layout.css.inverted-colors.enabled), disabled by default. This bug is for discussing whether/when to ship. Safari has shipped for a long while and I'm in the process of implementing in Chrome.

Comment 1

[Sebastian Zartner [:sebo]]

Safari shipped this back in version 9.1, the WPTs are all passing when the pref is enabled and a quick live test under Windows confirmed that it works.

So, as far as I can see, the only thing that's missing is a reponse to the standards position request on this.
Then I guess this could be shipped.

Sebastian

Comment 2

[Luke Warlow]

Iirc correctly Firefox implemented this without the UA stylesheet which inverts images, so I don't think its fully matching. (This may have changed though)

Comment 3

[Sebastian Zartner [:sebo]]

Good point! It doesn't seem to be part of the UA stylesheet yet. So I've filed bug 1954218 for that.

Sebastian

Comment 4

[Emilio Cobos Álvarez [:emilio]]

See https://github.com/w3c/csswg-drafts/issues/9674 for that

Comment 5

[Sebastian Zartner [:sebo]]

Ah, thanks for the hint, Emilio!

Sebastian

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

See https://github.com/w3c/csswg-drafts/issues/9674 for that

So, as the spec. now doesn't require UAs anymore to add the UA stylesheet rule, what's holding the shipping of this feature back?
The spec. discussion doesn't seem to question the media feature itself but only whether it is solely on authors to take counter-measures on color inversion or whether UAs can or should still apply some smart inversion. For that, I've also replied on the spec. issue.

Sebastian

Comment 7

[Emilio Cobos Álvarez [:emilio]]

I commented on https://github.com/mozilla/standards-positions/issues/853, mostly asking for feedback from other people. From the CSS perspective this is obviously fine so it's more about the privacy vs. a11y trade-off.

Comment 8

[Luke Warlow]

Fwiw I implemented this in chromium but never shipped it because it was missing the UA stylesheet changes (chromium can't use feature media queries in their UA stylesheet).

If Firefox were to go ahead and ship this without the UA stylesheet I'd happily try and get it shipped in chrome to match.