1846498 - Create a button and panel for restarting the PBM session

Status: RESOLVED FIXED

(Firefox :: Private Browsing, enhancement, P2)

Description

[Emma Zühlcke [:emz]]

A data clearance Icon to create an explicit data deletion action.
Clicking the data clear button will close all tabs leaving you on a fresh browser browsing window session with a success message displayed.

Add a panel that opens on button click and asks the user for confirmation before clearing the PBM session. We also want to add a checkbox so the confirmation panel can be skipped if desired.

The clear button needs to:

1. Close all other PBM windows
2. Close all tabs in the current PBM window
3. (Block the window from being interacted with?)
4. Call the new PBM data clearing method added in Bug 1846494 and wait for it to resolve
5. (Unblock the window)

The implementation should integrate with Nimbus and support a pref to hide the UI until it's ready to ship.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1846498 - Add a restart PBM session button and panel for private windows. r=mconley!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1846498 - Hide the reset pbm feature behind a pref. r=Gijs!

Depends on D187223

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1846498 - Use moz-button-group for panel footer. r=Gijs!

Depends on D187268

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1846498 - Reset PBM feature tests. r=mconley!

Depends on D187223

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D187223	Bug 1846498 - Add a restart PBM session button and panel for private windows. r=mconley!	pbz	Gijs: Back Sep 17, 2023

:pbz, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 6

[Emma Zühlcke [:emz]]

Thanks BugBot, very helpful! I have actually already changed reviewers.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/439c5b41701a
Add a restart PBM session button and panel for private windows. r=desktop-theme-reviewers,mconley,dao
https://hg.mozilla.org/integration/autoland/rev/535f72d66f52
Reset PBM feature tests. r=mconley

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures on browser/components/privatebrowsing/test/browser/browser_privatebrowsing_resetPBM.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/653daffe1a6bf5db37121e7bf3f8ff98fdca3995

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_resetPBM.js | Test timed out

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_1089591_still_customizable_after_reset.js | Should be back in default state

Comment 9

[Emma Zühlcke [:emz]]

Thanks! Looking. Can't reproduce locally on my Windows machine so far.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60ad03ef732
Add a restart PBM session button and panel for private windows. r=desktop-theme-reviewers,mconley,dao
https://hg.mozilla.org/integration/autoland/rev/8ed837349a10
Reset PBM feature tests. r=mconley

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d60ad03ef732
https://hg.mozilla.org/mozilla-central/rev/8ed837349a10

Comment 12

[Henry Wilkes (they/them) [:henry-x]]

Hi, I happened to be looking in "CustomizableUI.sys.mjs". Just a small things I noticed: "reset-pbm-toolbar-button" is added conditionally to the default toolbar but it is added to existing toolbars unconditionally on update.

It doesn't make much of a difference on stable release right now, since the widget is not created anyway. But I think it does mean that pre-120 users (that got the update) will have "reset-pbm-toolbar-button" in their "browser.uiCustomization.state", but post-120 users (that did not get the update) will not. Depending on what you do in the future, it could make a difference when it comes to enabling this on stable.

Comment 13

[Emma Zühlcke [:emz]]

Thanks for highlighting this problem! That assessment seems correct. We most likely will need another migration once we roll this out to all users on release.