1846509 - Find Events panel height is not remembered after restart

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect, P2)

Description

[Roman]

Attachment: calendar.jpg

Steps to reproduce:

change the calendar layout within the kalender tab
closed thunderbird
opened thunderbird again

Actual results:

the calendar layout changed as wished
thunderbird closed as wished
thunderbird opened as wished, but the calendar layout reseted to prior default layout

Expected results:

thunderbird opened as wished and the calendar layout is saved just as altert within prior usage

Comment 1

[Martin Schröder [:mschroeder]]

Confirmed with Thunderbird 115.2.2 on macOS.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1846509 - Restore dimensions of calendar elements persisted in the XUL store. r=#thunderbird-reviewers

These values are correctly being restored to the elements' attributes but XUL does not honour them
any more. Convert to style rules.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8fd7c71256ab
Restore dimensions of calendar elements persisted in the XUL store. r=aleca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef10a9c2006b
Undo bad late CSS change. rs=me DONTBUILD

Comment 8

[Corey Bryant]

Geoff, would you like this fix uplifted to 128?

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9410732 [details]
Bug 1846509 - Restore dimensions of calendar elements persisted in the XUL store. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: some parts of the UI don't remember the size they were before restarting
Testing completed (on c-c, etc.): has been in beta since 129
Risk to taking this patch (and alternatives if risky): very low

Comment 10

[Corey Bryant]

Geoff, did you want to request uplift to esr128?

Comment 11

[Geoff Lankow (:darktrojan)]

Comment on attachment 9410732 [details]
Bug 1846509 - Restore dimensions of calendar elements persisted in the XUL store. r=#thunderbird-reviewers

Ah yeah, opened and closed the form a few times, must've picked the wrong box the last time.

Comment 12

[Corey Bryant]

Comment on attachment 9410732 [details]
Bug 1846509 - Restore dimensions of calendar elements persisted in the XUL store. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 128.1.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/7a2efc8607d9
https://hg.mozilla.org/releases/comm-esr128/rev/b9103ce0d072