184657 - GFX should use the newer nsIPrefService APIs instead of nsIPref

Status: RESOLVED FIXED

(Core :: Graphics, defect, P2)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Comment 2

[Roland Mainz]

caillon:
Any ETA for landing the gfx/-part of this work? I'd like to do some things for
1.4beta but would prefer to land this patch first because my changes will likely
make the current patch rotten... 

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 108888 [details] [diff] [review]
Patch

Please don't request reviews on my patches.  I caught several problems with
this patch since I attached it.  I will seek reviews when I am ready.

Comment 4

[Peter Weilbacher]

Interesting and a bit disturbing to see nsIPref used even in Thebes quite a bit.

Comment 5

[[e-mail]]

Attachment: v1

this catches all the easy cases; there are a few more left i'll tackle in a separate patch.

low priority, please feel free to punt til after fx3 :)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why are you working on it then? :-)

Comment 7

[[e-mail]]

gotta have something to break the monotony of blockers. ;)

Comment 8

[Reed Loden [:reed]]

dwitte, forget to land this?

Comment 9

[[e-mail]]

would be nice to land, probably needs some unrotting. if anyone wants to unrot and land it, i'd certainly appreciate it...

Comment 10

[Makoto Kato [:m_kato]]

Since many codes is changed after making a patch, we need more changes such as gfxQuartzFontCache.mm to fix this.

Comment 11

[Makoto Kato [:m_kato]]

Attachment: patch v2 for latest tree

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 369195 [details] [diff] [review]
patch v2 for latest tree

update dan's patch and add some files for gfxWindowPlatform and QuartzFontCache.

Comment 13

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/mozilla-central/rev/fec668a58714