Closed Bug 1846642 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41272 - [EditContext] Make EditContext properties read only

Categories

(Core :: DOM: Editor, task, P4)

Product:
Core
Component:
DOM: Editor
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41272 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41272
Details from upstream follow.

Dan Clark <daniec@microsoft.com> wrote:

[EditContext] Make EditContext properties read only

Per spec [1], the EditContext text, selectionStart, and selectionEnd
properties should be read-only.

Update the implementation to match the spec.

[1] https://w3c.github.io/edit-context/#editcontext-interface

Bug: 999184
Change-Id: I267600fe2bedffaf8df5d6ec7e6972074d97683a
Reviewed-on: https://chromium-review.googlesource.com/4740012
WPT-Export-Revision: 410ecd49eebfe03dda298d35a9834ffec6b517c2

Component: web-platform-tests → DOM: Editor
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
PASS: 9

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /editing/edit-context/edit-context-basics.tentative.html [wpt.fyi]
    • Testing EditContext Dictionary Init: FAIL (Chrome: PASS, Safari: FAIL)
    • A contenteditable element should remain editable after attaching and detaching EditContext.: FAIL (Chrome: PASS, Safari: FAIL)
    • EditContext can be associated with an element that is not in the tree.: FAIL (Chrome: PASS, Safari: FAIL)
    • If an element is removed from the tree, the associated EditContext remains connected to the element.: FAIL (Chrome: PASS, Safari: FAIL)
    • If an element's ancestor is removed from tree, the associated EditContext remains connected to the element.: FAIL (Chrome: PASS, Safari: FAIL)
    • .attachedElements() should return associated element: FAIL (Chrome: PASS, Safari: FAIL)
    • Testing EditContext update text, selection and layout: FAIL (Chrome: PASS, Safari: FAIL)
    • updateCharacterBounds(), characterBounds(), and characterBoundsRangeStart should work properly: FAIL (Chrome: PASS, Safari: FAIL)
    • Testing EditContext update text and selection with invalid values: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by ctuns@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/da75d0bfff56
[wpt PR 41272] - [EditContext] Make EditContext properties read only, a=testonly

https://hg.mozilla.org/mozilla-central/rev/da75d0bfff56

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.