1846667 - "Translate this page?" dialog flashes for an instant and then disappears during session restore

Status: RESOLVED DUPLICATE of bug 1846828

(Firefox :: Translations, defect)

Description

[Daniel Holbert [:dholbert]]

I don't have concrete STR, but I've noticed that in my current browsing session (and I've noticed it in previous sessions as well), if I quit and restart Firefox, then my foreground page (which right now happens to be https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input ) flashes a "Translate this page?" dialog at its lower-right corner for just an instant (as in: it paints for literally a single animation frame, and that's it).

I can't reproduce in a fresh profile, but I've seen this on multiple different machines (with my regular browsing profile).

I'm using Nightly 118.0a1 (2023-08-01) (64-bit) on Ubuntu 22.04.

Comment 1

[Daniel Holbert [:dholbert]]

I captured a profile of the relevant portion of my Firefox startup process with my regular browsing profile, for a time when this happened:
https://share.firefox.dev/45aPACB

Note the two screenshot tracks shown in the profile -- one for MDN, the other for a "Translate this page?" dialog.

You can't tell this from looking at the profile, but in real life when this profile was recording, the "Translate this page?" dialog just briefly flickered to be visible for a fraction of a second and then disappeared, over the bottom right corner of my MDN page.

Comment 2

[Greg Tatum [:gregtatum]]

Thanks! This is really helpful. I've not been able to reproduce, but I can try on my Ubuntu machine. I'm assuming your browser is set to English for web content. This is popping up as a en -> null translation, which shouldn't happen anyway.

Comment 3

[Daniel Holbert [:dholbert]]

Yes, I have my browser set to English for web content (standard default en-US setup in the US, no preference expressed for other languages).

(Also, FWIW, I just edited comment 0 to correct one typo: I had initially said "if I quit Firefox" but I meant to say "quit and restart Firefox" -- i.e. this manifests on startup session-restore for me.)

A few other tips in case it's relevant:

• I used the Firefox Translations extension before this was built-in (so it's conceivable that my profile has some left-over state from that which is involved in triggering this).
• In Firefox Preferences "Translations" section, I have no languages installed [every listed one shows up with an un-clicked "Install" button], and the Translation "Settings" button's dialog has all of the sections being empty (no languages/sites are listed in the boxes there).
• I have these translations-related pref values:

browser.translations.panelShown	true	
extensions.translations.disabled	false	
extensions.webex[e-mail]	true	
services.settings.main.translations-identification-models.last_check	1690996136	
services.settings.main.translations-models.last_check	1690996136	
services.settings.main.translations-wasm.last_check

Comment 4

[Greg Tatum [:gregtatum]]

Erik and I were looking through the code today, and a few issues that may clear this up. I haven't reproduced on a machine still, but Bug 1846828 may fix this.

For sure in your profiler run, the offering was "en" -> null which shouldn't be offered. I added additional logic checks to guard for this in Bug 1846828 and additional race condition checks for if we try to open multiple popups at once, to only allow one popup to be initialized and shown at a time.

Comment 5

[Greg Tatum [:gregtatum]]

Can those affected by this let me know if it's still happening. I found a reason errant popups were happening in Bug 1846828 and fixed it. Make sure to be on the latest Nightly. There is an uplift that is making its way to Beta as well.

Comment 6

[Daniel Holbert [:dholbert]]

Not happening for me anymore! I tried on two machines where I had been seeing it in the past, and I haven't been able to trigger it with latest Nightly.

--> Seems likely to be dupe of bug 1846828 (i.e. fixed by the patches there).

Thanks!