1846744 - Intermittent /webdriver/tests/bidi/script/call_function/arguments.py | test_primitive_value[Number.NaN-argument4] - webdriver.bidi.modules.script.ScriptEvaluateResultException: Error: Argument should be Number.NaN, but was NaN

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This test fails upstream on wpt.fyi for all the browsers with:

  FAIL test_primitive_value[Number.NaN-argument4] - webdriver.bidi.modules.script.ScriptEvaluateResultException: Error: Argument should be Number.NaN, but was NaN
bidi_session = <webdriver.bidi.client.BidiSession object at 0x107cab3a0>
top_context = {'children': [], 'context': '4068abf3-5df0-4269-a378-7d2e896d4d99', 'parent': None, 'url': 'about:blank'}
argument = {'type': 'number', 'value': 'NaN'}, expected = 'Number.NaN'

    @pytest.mark.asyncio
    @pytest.mark.parametrize("expected, argument", PRIMITIVE_VALUES)
    async def test_primitive_value(bidi_session, top_context, argument, expected):
>       result = await bidi_session.script.call_function(
            function_declaration=f"""(arg) => {{
                if (arg !== {expected}) {{
                    throw new Error(`Argument should be {expected}, but was ` + arg);
                }}
                return arg;
            }}""",
            arguments=[argument],
            await_promise=False,
            target=ContextTarget(top_context["context"]),
        )

argument   = {'type': 'number', 'value': 'NaN'}
bidi_session = <webdriver.bidi.client.BidiSession object at 0x107cab3a0>
expected   = 'Number.NaN'
top_context = {'children': [],
 'context': '4068abf3-5df0-4269-a378-7d2e896d4d99',
 'parent': None,
 'url': 'about:blank'}

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem here is that the NaN check needs to be done by using isNaN(), which is not done here. But there is a separate test test_primitive_value_NaN which does it right and duplicates it.

One idea was to remove NaN from PRIMITIVE_VALUES but that's not good for other tests. As such we might need some funky checks in the callFunction call. Note that isNaN() also fails for BigInt values.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1846744 - [wdspec] Fix call_function/arguments.py | test_primitive_value for Number.NaN.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe331e7b17f9
[wdspec] Fix call_function/arguments.py | test_primitive_value for Number.NaN. r=webdriver-reviewers,jdescottes

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41290 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fe331e7b17f9

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot