1846750 - Perma mass failures timeouts | L10nRegistry error: Missing resource in locale en-US: preview/shopping.ftl when Gecko 118 merges to Beta on 2023-08-28

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P3)

Description

[Sandor Molnar[:smolnar]]

Central as beta-simulation

How to run these simulations

Failure log Mn

Failure log mochitest

DEBUG: Adding blocker SitePermsAddonProvider for phase AddonManager: Waiting for providers to shut down.
[task 2023-08-02T11:06:49.917Z] 11:06:49     INFO -  [Parent 857, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:1759
[task 2023-08-02T11:06:49.918Z] 11:06:49     INFO -  DEBUG: Adding blocker GMPProvider for phase AddonManager: Waiting for providers to shut down.
[task 2023-08-02T11:06:49.960Z] 11:06:49     INFO -  DEBUG: Adding blocker JSON store: writing data for 'handlers' for phase IOUtils: waiting for profileBeforeChange IO to complete
[task 2023-08-02T11:06:49.979Z] 11:06:49     INFO -  [Child 960, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:655
[task 2023-08-02T11:06:50.033Z] 11:06:50     INFO -  [WARN  l10nregistry_ffi::env] L10nRegistry error: Missing resource in locale en-US: preview/shopping.ftl
[task 2023-08-02T11:06:50.035Z] 11:06:50     INFO -  [fluent] Couldn't find a message: browser-main-window-window-titles

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e9ef633550ad05247241fad1456fc73f10e7ec99#l4.1 adds new buttons and their text is stored in shopping.ftl https://hg.mozilla.org/mozilla-central/rev/e9ef633550ad05247241fad1456fc73f10e7ec99#l6.1
But we only ship that file for Nightly: https://searchfox.org/mozilla-central/rev/85269d4444c2553e7f4c669fe4de72d64f4fe438/browser/locales/jar.mn#15-17

Comment 2

[Fred Chasen [:fchasen]]

Thanks, checking if we can include preview/shopping.ftl in all builds - either way should have a patch up shortly.

Comment 3

[Fred Chasen [:fchasen]]

Attachment: Bug 1846750 - Only enable shopping button on Nightly r?#shopping-reviewers

Comment 4

[Fred Chasen [:fchasen]]

We are going to only load the shopping.ftl for Nightly now to fix this issue.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1b8ac5d40ae
Only enable shopping button on Nightly r=shopping-reviewers,jhirsch

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c1b8ac5d40ae

Comment 7

[Iulian Moraru]

After using https://phabricator.services.mozilla.com/D185189 in the latest central as early beta simulation, has uncovered more mass failures as it can be seen here.
The issue now, after using the latest patch, seems to be here: https://treeherder.mozilla.org/logviewer?job_id=424777998&repo=try&lineNumber=1748 JavaScript error: chrome://browser/content/browser.js, line 9952: Error: Failed to load resource:///actors/ShoppingSidebarParent.sys.mjs

Hi Fred! Can you please take another look at this?
Thank you!

Comment 8

[Fred Chasen [:fchasen]]

Attachment: Bug 1846750 - Only enable ShoppingSidebarManager on Nighly builds r?#shopping-reviewers

Updates ShoppingSidebarManager init, uninit and onLocationChange to only be called when AppConstants.NIGHTLY_BUILD is true.

Comment 9

[Fred Chasen [:fchasen]]

Thanks for looking into this more Iulian.

I'm continuing to try and understand why that file isn't present outside of Nightly but for now I think the best path is the patch above to only init the ShoppingSidebarManager in a Nightly builds.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a8e173a97d0
Only enable ShoppingSidebarManager on Nighly builds r=shopping-reviewers,Gijs

Comment 11

[Noemi Erli[:noemi_erli]]

Patch is working on today's beta simulation push

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The file is only available in Nightly because browser/components/shopping only ships there

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3a8e173a97d0

Comment 14

[Cosmin Sabou [:CosminS]]

Verified fix in today's beta-sim.