1846755 - :has invalidation WPT failure - target-pseudo-in-has.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Shin[:dshin]]

This fails but not due to :has invalidation - in fact, the location of the assertion failure is:

fragmentLink("fragment").click();

assert_true(fragment.matches(":target"));

Comment 1

[Daniel Holbert [:dholbert]]

wpt.fyi link: https://wpt.fyi/results/css/selectors/invalidation/target-pseudo-in-has.html

Comment 2

[David Shin[:dshin]]

When the test is opened, all three line items are grey, and the first turns green when the inspector is opened.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I'm not sure that :target is guaranteed to change synchronously on fragment navigation. Test might need to wait on hashchange or so?

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1846755: Make target-pseudo-in-has.html wait for `hashchange` event. r=#layout-reviewers

There's no guarantee on element.click() to :target invalidation happening
synchronously; wait for hashchange event to fire before testing for invalidation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/748270842d82
Make target-pseudo-in-has.html wait for `hashchange` event. r=layout-reviewers,emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43005 for changes under testing/web-platform/tests

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/748270842d82

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot