Closed Bug 1846794 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41292 - Drop funcsigs (redux)

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41292 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41292
Details from upstream follow.

ahochheiden <ahochheiden@mozilla.com> wrote:

Drop funcsigs (redux)

#37150 tried to drop funcsigs, but this broke both WebKit and Servo importers, and this was reverted in #37442.

To quote https://github.com/web-platform-tests/wpt/pull/37442#issuecomment-1662481999:

ef70ce9 left tools/third_party/funcsigs/docs/index.rst as a symlink to the (non-existent, removed) tools/third_party/funcsigs/docs/README.rst, which I believe is the origin of all the problems here.

This re-lands #37150 and additionally deletes the entirety of tools/third_party/funcsigs (including the broken symlink).

I've confirmed the WebKit importer continues to work with this landed; I have not tried the Servo importer (cc @jdm).

(We should make sure we squash this prior to landing, but this sequence of commits makes it clear what's changed since we previously landed it for review purposes.)

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by ctuns@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/fbb0beabc8be
[wpt PR 41292] - Drop funcsigs (redux), a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.